feat: add function to get day of omer #20
Conversation
|
Closes #17 |
|
There are two failing tests, but I don't understand their messages |
src/Moadim/Omer.php
Outdated
| public function getOmerCount() | ||
| { | ||
| if ($this->jewishMonth == 8 && $this->jewishDay >= 16) { | ||
| return $this->jewishDay - 15; | ||
| } | ||
| if ($this->jewishMonth == 9) { | ||
| return $this->jewishDay + 15; | ||
| } | ||
| if ($this->jewishMonth == 10 && $this->jewishDay <= 5) { | ||
| return $this->jewishDay + 44; | ||
| } | ||
|
|
||
| return 0; | ||
| } |
There was a problem hiding this comment.
Can we return null when the count is not applicable rather than 0?
Also, what do you think about something like this instead:
$count = $this->diffInDays(
static::firstDayOfPesach($this->jewishYear)
);
return $count > 0 && $count < 50 ? $count : null;There was a problem hiding this comment.
I thought about that, but my logic was that the Omer days don't actually change from year to year, and it's slightly quicker and less resource intensive to just check the date than to create another object and compare the difference in days. In the end of the day it's your choice, but that's why I went this route
|
I can run lint on this soon, thanks for letting me know that I can do that |
|
I ran lint on the code (and I still can't tell the difference), but one of the checks is still failing |
tam5
changed the title
No description provided.