Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint description #218

Merged
merged 1 commit into from Apr 13, 2018
Merged

Fix lint description #218

merged 1 commit into from Apr 13, 2018

Conversation

tdsmith
Copy link
Contributor

@tdsmith tdsmith commented Apr 13, 2018

The lint description was incorrectly duplicated from e_sub_cert_eku_server_auth_client_auth_missing.

Discussion at https://groups.google.com/d/msg/mozilla.dev.security.policy/qeP4LBr72kI/pgfovCB6BAAJ.

The lint description was incorrectly duplicated from `e_sub_cert_eku_server_auth_client_auth_missing`.
Copy link
Contributor

@justinbastress justinbastress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tdsmith. Looks good.

@justinbastress justinbastress merged commit f6e1d28 into zmap:master Apr 13, 2018
@tdsmith tdsmith deleted the patch-1 branch August 1, 2018 06:09
aaomidi pushed a commit to aaomidi/zlint that referenced this pull request Nov 29, 2022
The `unknown_sig_alg.cert` test case of the `TestCertificateJSON` test
from `x509/json_test.go` had to have its expected JSON updated. Go
1.14.x does a better job of parsing this certificate's subject/issuer
than prev. versions and so there are more fields present in the output
JSON.

Vendoring has lost favour compared to relying on the Go 1.13+
proxy/module checksum behaviour[0].

Removing the vendor dir also lets us remove an annoying `find`
workaround for using `gofmt` directly in the fmt checking diff without
re-downloading deps.

[0]: https://proxy.golang.org/

zmap/zcrypto#218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants