Fix lint description #218
Merged
Fix lint description #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lint description was incorrectly duplicated from `e_sub_cert_eku_server_auth_client_auth_missing`.
justinbastress
approved these changes
Apr 13, 2018
aaomidi
pushed a commit
to aaomidi/zlint
that referenced
this pull request
Nov 29, 2022
The `unknown_sig_alg.cert` test case of the `TestCertificateJSON` test from `x509/json_test.go` had to have its expected JSON updated. Go 1.14.x does a better job of parsing this certificate's subject/issuer than prev. versions and so there are more fields present in the output JSON. Vendoring has lost favour compared to relying on the Go 1.13+ proxy/module checksum behaviour[0]. Removing the vendor dir also lets us remove an annoying `find` workaround for using `gofmt` directly in the fmt checking diff without re-downloading deps. [0]: https://proxy.golang.org/ zmap/zcrypto#218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint description was incorrectly duplicated from
e_sub_cert_eku_server_auth_client_auth_missing.Discussion at https://groups.google.com/d/msg/mozilla.dev.security.policy/qeP4LBr72kI/pgfovCB6BAAJ.