Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elite pi #21

Open
wants to merge 6 commits into
base: v3.2.0+zmk-fixes
Choose a base branch
from
Open

Add elite pi #21

wants to merge 6 commits into from

Conversation

Na-Cly
Copy link

@Na-Cly Na-Cly commented May 3, 2023

Not sure if this is all correct or not, but seems to be working for me.

Copy link

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few thoughts.

boards/arm/elite_pi_rp2040/elite_pi_pro_micro.dtsi Outdated Show resolved Hide resolved
boards/arm/elite_pi_rp2040/elite_pi_pro_micro.dtsi Outdated Show resolved Hide resolved
boards/arm/elite_pi_rp2040/elite_pi_pro_micro.dtsi Outdated Show resolved Hide resolved
gpio-map-mask = <0xffffffff 0xffffffc0>;
gpio-map-pass-thru = <0 0x3f>;
gpio-map
= <0 0 &gpio0 12 0> /* D12/SDA0 */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the comments on the alternate functions here accurate? Are there any additional peripheral busses, etc expected on these pins?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. I was using this documentation. https://docs.keeb.io/elite-pi-guide

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's elite-pi specific. Remove that alternate function from the comments here, they should be treated as just GPIO pins.

Na-Cly and others added 4 commits May 8, 2023 09:04
Co-authored-by: Pete Johanson <peter@peterjohanson.com>
Co-authored-by: Pete Johanson <peter@peterjohanson.com>
Co-authored-by: Pete Johanson <peter@peterjohanson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants