Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shields) Add Redox Shield Support #1002

Merged
merged 7 commits into from
Dec 2, 2021
Merged

feat(shields) Add Redox Shield Support #1002

merged 7 commits into from
Dec 2, 2021

Conversation

toddmok
Copy link
Contributor

@toddmok toddmok commented Oct 25, 2021

Added support for the Redox shield. Tested on my redox build. New Board/Shield Check-list completed.
https://github.com/mattdibi/redox-keyboard

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • Definitions follow the general style of other shields/boards upstream (Reference)
  • .zmk.yml metadata file added
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • General consistent formatting of DeviceTree files
  • Keymaps do not use deprecated key defines (Check using the upgrader tool)
  • &pro_micro used in favor of &pro_micro_d/a if applicable
  • If split, no name added for the right/peripheral half
  • .conf file has optional extra features commented out

@Nicell Nicell added enhancement New feature or request shields PRs and issues related to shields labels Oct 26, 2021
Nicell
Nicell requested changes Oct 26, 2021
View reviewed changes
Copy link
Member

@Nicell Nicell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of first-pass comments.

app/boards/shields/redox/redox_right.conf Outdated Show resolved Hide resolved
app/boards/shields/redox/boards/nice_nano.overlay Outdated Show resolved Hide resolved
@toddmok toddmok requested a review from Nicell October 26, 2021 04:37
Nicell
Nicell requested changes Nov 28, 2021
View reviewed changes
app/boards/shields/redox/Kconfig.shield Show resolved Hide resolved
app/boards/shields/redox/Kconfig.defconfig Outdated Show resolved Hide resolved
app/boards/shields/redox/Kconfig.defconfig Outdated Show resolved Hide resolved
app/boards/shields/redox/redox.zmk.yml Show resolved Hide resolved
@toddmok
requested changes
6c1216c 
add underglow, add copyright, remove display
@toddmok toddmok requested a review from Nicell November 28, 2021 20:44
Nicell
Nicell requested changes Nov 28, 2021
View reviewed changes
Copy link
Member

@Nicell Nicell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing with displays, then could you test the build output of this shield on your actual hardware with the changes you've made?

Nicell
Nicell reviewed Nov 28, 2021
View reviewed changes
Copy link
Member

@Nicell Nicell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, didn't get attached to last review

app/boards/shields/redox/redox.dtsi Outdated Show resolved Hide resolved
Nicell
Nicell requested changes Nov 29, 2021
View reviewed changes
app/boards/shields/redox/Kconfig.defconfig Outdated Show resolved Hide resolved
app/boards/shields/redox/Kconfig.shield Outdated Show resolved Hide resolved
@toddmok
Copy link
Contributor Author

toddmok commented Dec 1, 2021

One last thing with displays, then could you test the build output of this shield on your actual hardware with the changes you've made?

I've committed all changes, and tested on my redox hardware after all changes. Thanks for the feedback and helping sort through the updates.

@toddmok toddmok requested a review from Nicell December 1, 2021 02:57
Nicell
Nicell reviewed Dec 1, 2021
View reviewed changes
Copy link
Member

@Nicell Nicell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thought on the keymap, and then otherwise it's looking good! Great job on this definition 😄

app/boards/shields/redox/redox.keymap Outdated Show resolved Hide resolved
@Nicell Nicell merged commit 9148ffd into zmkfirmware:main Dec 2, 2021
scrthq pushed a commit to scrthq/zmk that referenced this pull request Dec 26, 2021
@toddmok @scrthq
feat(shields) Add Redox Shield Support (zmkfirmware#1002)
ff5e882 
* Add redox shield support

* typo

* Pull request fixes

* requested changes

add underglow, add copyright, remove display

* remove because of no display

* comment fix

* bt clear
@mattdibi mattdibi mentioned this pull request Jan 16, 2022
Open
PedroDiogo pushed a commit to PedroDiogo/zmk that referenced this pull request Feb 7, 2022
@toddmok @PedroDiogo
feat(shields) Add Redox Shield Support (zmkfirmware#1002)
7907cb9 
* Add redox shield support

* typo

* Pull request fixes

* requested changes

add underglow, add copyright, remove display

* remove because of no display

* comment fix

* bt clear
mirandaflu pushed a commit to mirandaflu/zmk that referenced this pull request Jun 5, 2022
@toddmok @mirandaflu
feat(shields) Add Redox Shield Support (zmkfirmware#1002)
fad21e1 
* Add redox shield support

* typo

* Pull request fixes

* requested changes

add underglow, add copyright, remove display

* remove because of no display

* comment fix

* bt clear
tyalie pushed a commit to tyalie/zmk that referenced this pull request Nov 15, 2022
@toddmok
feat(shields) Add Redox Shield Support (zmkfirmware#1002)
af54377 
* Add redox shield support

* typo

* Pull request fixes

* requested changes

add underglow, add copyright, remove display

* remove because of no display

* comment fix

* bt clear
NikolaRavic pushed a commit to NikolaRavic/zmk-firmware that referenced this pull request Feb 27, 2023
@toddmok @NikolaRavic
feat(shields) Add Redox Shield Support (zmkfirmware#1002)
edacfc9 
* Add redox shield support

* typo

* Pull request fixes

* requested changes

add underglow, add copyright, remove display

* remove because of no display

* comment fix

* bt clear
yuanbin pushed a commit to yuanbin/zmk that referenced this pull request Jun 14, 2023
@toddmok
feat(shields) Add Redox Shield Support (zmkfirmware#1002)
1bad861 
* Add redox shield support

* typo

* Pull request fixes

* requested changes

add underglow, add copyright, remove display

* remove because of no display

* comment fix

* bt clear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nicell Nicell Nicell approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request shields PRs and issues related to shields
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@toddmok @Nicell