Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant Kconfig defaults #2161

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

lesshonor
Copy link
Contributor

As discussed on Discord:

petejohanson: We shouldn't ever explicitly set a default n
petejohanson: Because it causes the problem you describe
petejohanson: https://docs.zephyrproject.org/latest/build/kconfig/tips.html#redundant-defaults

Only ZMK symbols were modified; BT_GATT_NOTIFY_MULTIPLE was intentionally omitted. While seemingly unlikely given the age of git blame...it's still possible that the default value of this symbol could be changed at some later date in Zephyr, so I left it alone.

bool symbols implicitly default to n.
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@petejohanson petejohanson merged commit ccf0380 into zmkfirmware:main Feb 20, 2024
45 checks passed
@lesshonor lesshonor deleted the refactor/kconfig-defaults branch February 21, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants