remove buggy url encoding #830
Conversation
|
How much will it take to merge this fix? it worked for me locally but i would love if it's available in the package. |
|
Could you please give some example of context working after and before? Is it still working on with filename with spaces? |
|
This look like to be the opposite of this fix 3fe5480 |
Yes that fix causes this problem. #628 (comment) from that PR points this out. Frankly, I don't believe URI encoding should be done by this library to begin with as there are very likely more effective libraries that accomplish URI encoding and would allow encoded URIs to be passed to this library. It would make more sense for the users of this library to be responsible for passing an appropriate URI to this library rather than have default URI encoding in this library that enables some inputs to work but prevents others from working. The current URI encoding in this library seems like a premature optimization since it arguably causes as many if not more more problems than it solves. |
|
Can we merge it? |
|
@RomualdPercereau I had to revert the change made in this 3fe5480. and now it works perfectly fine. So Could we merge please |
Fixes #500