TDNS: Fix a use-after-free-race-with-threads

Signed-off-by: Uli Schlachter <psychon@znc.in>
znc · Jan 19, 2012 · beacc01 · beacc01
1 parent 6a2b5a2
commit beacc01
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/Socket.cpp b/src/Socket.cpp
@@ -76,7 +76,8 @@ void* CSockManager::TDNSThread(void* argument) {
 		sleep(5); // wait 5 seconds before next try
 	}
 
-	pthread_mutex_lock(a->mutex);
+	pthread_mutex_t* mutex = a->mutex;
+	pthread_mutex_lock(mutex);
 	int wrote = 0;
 	int need = sizeof(TDNSArg*);
 	char* x = (char*)&a;
@@ -89,7 +90,7 @@ void* CSockManager::TDNSThread(void* argument) {
 		wrote += w;
 		x += w;
 	}
-	pthread_mutex_unlock(a->mutex);
+	pthread_mutex_unlock(mutex);
 	return NULL;
 }