Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of #18 #48

Merged
merged 2 commits into from
Jun 15, 2016
Merged

Update of #18 #48

merged 2 commits into from
Jun 15, 2016

Conversation

jamadden
Copy link
Member

This time including one other StorageError that users might legitimately want to distinguish.

…quireCommitLockError, when acquiring the commit lock fails.
People might reasonably want to catch these in code and handle them
gracefully.

(Contrast with the errors raised by schema.py: those are strictly
operational and shouldn't affect a running app.)
@coveralls
Copy link

coveralls commented Jun 14, 2016

Coverage Status

Coverage increased (+0.02%) to 76.482% when pulling 999af07 on commit-lock-ex into 36a489f on master.

@jamadden
Copy link
Member Author

LGTM. Any reviewers or objections to merging?

@jamadden jamadden merged commit e20d8b9 into master Jun 15, 2016
@jamadden jamadden deleted the commit-lock-ex branch January 4, 2017 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants