Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue testing angular demo #37

Closed
x20mar opened this issue Apr 22, 2014 · 8 comments
Closed

Issue testing angular demo #37

x20mar opened this issue Apr 22, 2014 · 8 comments

Comments

@x20mar
Copy link

x20mar commented Apr 22, 2014

Hi,

I'm trying to run the angular demos but on both of them I get the following error

Error: this.audio is undefined
FlashAudioPlayer.prototype.play@file:///home/lucy/Downloads/audio5js-master/src/audio5.js:430
Audio5js.prototype.play@file:///home/lucy/Downloads/audio5js-master/src/audio5.js:828
Audio5js.prototype.playPause@file:///home/lucy/Downloads/audio5js-master/src/audio5.js:843
Mc/u/<@http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:70
dc[c]</</</<@http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:141
Sc/this.$get</e.prototype.$eval@http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:86
Sc/this.$get</e.prototype.$apply@http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:86
dc[c]</</<@http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:140
pc/c/<@http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:22
m@http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:6
pc/c@http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:22
"

Also on a side note is there anyway to state that you don't want a flash fallback?

Thanks

@zohararad
Copy link
Owner

@x20mar I'm afraid the Angular demo wasn't done by me - I'm not an Angular person. I tried reaching out to the developer who did it but he was unresponsive. My suggestion is to look at the principle and then rewrite it yourself.

There's currently no way to state you don't want a Fallback but as long as the Flash isn't required it won't be used.

@sethlesky
Copy link
Contributor

@x20mar @x20mar After updating to Chrome 36.0.1985.125 (about 16 hours ago), I'm seeing the error below which seems similar to @x20mar. Older versions of Chrome and the most recent Safari and Firefox run that Angularjs example without issue.

It seems in both cases the FlashAudioPlayer fallback is failing. Since I'm using Chrome I'm no sure why it's falling back to begin with.

I'm curious which browser you were testing with, and if anyone has insights.

TypeError: Cannot read property 'pplay' of undefined
at Object.FlashAudioPlayer.play (file:///Users/sethlesky/playground/audio5js/src/audio5.js:432:17)
at Object.Audio5js.play (file:///Users/sethlesky/playground/audio5js/src/audio5.js:832:20)
at Object.Audio5js.playPause (file:///Users/sethlesky/playground/audio5js/src/audio5.js:847:44)
at http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:70:299
at http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:140:525
at Object.e.$eval (http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:86:310)
at Object.e.$apply (http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:86:417)
at HTMLButtonElement. (http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:140:507)
at http://ajax.googleapis.com/ajax/libs/angularjs/1.0.3/angular.min.js:22:462
at Array.forEach (native)

In case these issue are not related I created a ticket here:
#41

@cihank
Copy link

cihank commented Aug 27, 2014

2 of the demos are working for me Chrome 36.0.1985.143. May this issue is already fixed ?

@zohararad
Copy link
Owner

@cihank the angular demos were not created by me but rather by @altryne . The issues with Chrome 36 compatibility were fixed separately. I suggest using the release from master branch in your own code and your own Angular implementation

@mikerudolph
Copy link
Contributor

I can confirm the Angular demos are working fine for me

@belldandu
Copy link

@zohararad this issue looks to have been resolved but you never closed it.

@zohararad
Copy link
Owner

must've missed it @KamijouTouma closing now (thanks for your help in cleaning up things)

@belldandu
Copy link

No problem ;) @zohararad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants