Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio5js no longer playing after updating to latest Chrome 36.0.1985.125 #41

Closed
sethlesky opened this issue Jul 17, 2014 · 5 comments
Closed

Comments

@sethlesky
Copy link
Contributor

After updating the the latest version of Chrome (36.0.1985.125) I'm getting the following error:

TypeError: Cannot read property 'pplay' of undefined
at Object.FlashAudioPlayer.play (http://localhost:9000/components/audio5js/audio5.js:433:17)
at Object.Audio5js.play (http://localhost:9000/components/audio5js/audio5.js:835:20)
at Object.Audio5js.playPause (http://localhost:9000/components/audio5js/audio5.js:850:44)
at http://localhost:9000/bower_components/angular/angular.js:10773:21
at http://localhost:9000/bower_components/angular/angular.js:18981:17
at Scope.$eval (http://localhost:9000/bower_components/angular/angular.js:12608:28)
at Scope.$apply (http://localhost:9000/bower_components/angular/angular.js:12706:23)
at HTMLSpanElement. (http://localhost:9000/bower_components/angular/angular.js:18980:21)
at HTMLSpanElement.jQuery.event.dispatch (http://localhost:9000/bower_components/jquery/dist/jquery.js:4641:9)
at HTMLSpanElement.elemData.handle (http://localhost:9000/bower_components/jquery/dist/jquery.js:4309:46)

No issue with latest versions of Firefox and Safari. Seems to do something with incorrectly falling back to flash instead of using HTML5 audio?

Excellent audio player, hopefully this can be figured out soon.

@zohararad
Copy link
Owner

This indeed seems like a Flash issue. However as I'm away I won't be able to look at it for at least a week. Could it be that Flash is either not enabled at all (check about:config) or there's a conflict with system-wide version of Flash?

Either way I'll try to look at it asap

@sethlesky
Copy link
Contributor Author

System and Chrome versions are the same for both the new version and older (working) version of Chrome. Adobe Flash Player (Version: 14.0.0.145).

Should the flash fallback be used when playing audio in Chrome? I believe the previous release of Chrome used the HTML5AudioPlayer object instead of FlashAudioPlayer, which leads to think that whatever condition that determines whether HTML5 audio is available is no longer reliable.

Thanks for taking a look @zohararad

@sethlesky
Copy link
Contributor Author

@zohararad the issue was in Chrome
canPlayType('audio/mpeg; codecs="mp3"') returns ''

Looks like it's being worked on here:
https://codereview.chromium.org/390413002/

@sethlesky
Copy link
Contributor Author

http://code.google.com/p/chromium/issues/detail?id=393720#c10

"The 'audio/mpeg; codecs="mp3"' mimetype is not RFC 3003 compliant, but a
bunch of sites apparently use it. This change restores the behavior that
was in M35 and earlier and returns "probably" for this mimetype."

To be on the safe side maybe use 'audio/mpeg;' as the mimetype instead.

@zohararad
Copy link
Owner

@sethlesky I just merged your PR with fix for MP3 mime-type. I assume closing this issue is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants