Issue #554 - Adding Farmers::Fork

[emilianodellacasa]

To solve issue #554 I added the new class Farmers::Fork that is using Process.fork instead of Open3

Please note that inside the library, Farmers::Spawn is still the default

[0crat]

Job #567 is now in scope, role is REV

[0crat]

@yegor256/z everybody who has role REV is banned at #567; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

[yegor256]

@emilianodellacasa what's the point of doing fork and creating a new process? :)

[yegor256]

@emilianodellacasa you are saying "instead" but your code still calls Open3.popen2e

[codecov-io]

Codecov Report

Merging #567 into master will decrease coverage by 0.2%.
The diff coverage is 27.27%.

@@            Coverage Diff             @@
##           master     #567      +/-   ##
==========================================
- Coverage   34.62%   34.42%   -0.21%     
==========================================
  Files          65       65              
  Lines        2992     3027      +35     
==========================================
+ Hits         1036     1042       +6     
- Misses       1956     1985      +29

Impacted Files	Coverage Δ
lib/zold/node/farmers.rb	28.39% <27.27%> (-4.26%)	⬇️
lib/zold/sync_wallets.rb	47.36% <0%> (-2.64%)	⬇️
lib/zold/remotes.rb	30.81% <0%> (-0.63%)	⬇️
lib/zold/node/async_entrance.rb	28.57% <0%> (-0.52%)	⬇️
lib/zold/commands/node.rb	19.09% <0%> (-0.09%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22ea23b...16337b4. Read the comment docs.

[emilianodellacasa]

@yegor256 Ooooops, sorry about that, now the code makes sense :-)

[yegor256]

@emilianodellacasa still a miss. You don't need to use posix processes inside fork. Fork already creates you a separate process. Why do you want to create another one inside?

[emilianodellacasa]

@yegor256 I don't get it: I need a separate process to run the command that calculates the score, this is the reason why I am using another process for it.

[yegor256]

@emilianodellacasa you get that process by calling fork. Then, you just calculate the score inside the method. Just like it's done in Farmers::Plain:

class Fork
  def up(score)
    fork do
      score.next
    end
  end
end

[emilianodellacasa]

@yegor256 You are definitely right, I was missing the whole concept of score.next

[yegor256]

@emilianodellacasa how many more pid-s you have here? https://www.yegor256.com/2015/01/12/compound-name-is-code-smell.html

[emilianodellacasa]

@yegor256 Done

[yegor256]

@emilianodellacasa I would rename them to stdin and stdout

[emilianodellacasa]

@yegor256 Done

[yegor256]

@emilianodellacasa you can do:

buffer, pid = output.split('|')

[emilianodellacasa]

@yegor256 Right, done

[yegor256]

@emilianodellacasa see above

[emilianodellacasa]

@yegor256 All done, see my commits

[yegor256]

@rultor merge

[rultor]

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 8min)

[0crat]

Job gh:zold-io/zold#567 is not assigned, can't get performer

[0crat]

The job #567 is now out of scope