You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
@kch this is nice, but there's a problem -- since it will be before airbrake/exceptional/etc, timeouts will be silently ignored by these systems.
i have a fork of rack-timeout where i built a feature to allow the user to specify a reporter lambda for timeouts. i actually haven't used it in production for a while and in general it could use some cleaning up. if this sounds interesting i can make a tidy pull request
On 16 May 2013 03:20, John Joseph Bachir ***@***.*** wrote:
@kchhttps://github.com/kch did the heroku branch get merged into
master? (the branch seems to be missing but i don't see the merge in the
changelog)
—
Reply to this email directly or view it on GitHubhttps://github.com/kch/rack-timeout/commit/2888a5e73d58002d8c5c8877b4bfd38053b81741#commitcomment-3223126
.
The reason will be displayed to describe this comment to others. Learn more.
ahh, gotcha!
BTW, to be clear, I NEVER ran my branch in production. It was a side project I hacked on for a few days but didn't have time to get into good enough shape to deploy.
2888a5e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kch this is nice, but there's a problem -- since it will be before airbrake/exceptional/etc, timeouts will be silently ignored by these systems.
i have a fork of rack-timeout where i built a feature to allow the user to specify a reporter lambda for timeouts. i actually haven't used it in production for a while and in general it could use some cleaning up. if this sounds interesting i can make a tidy pull request
jjb@ddcf82b
2888a5e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm they actually get ignored? Since the timeout error is raised in the application thread, I'd think it would not matter.
2888a5e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, you might want to checkout the heroku branch.
This is most likely wherefrom a next release would be based off. It looks to me like your reporter could tie into
set_state_and_log!
.2888a5e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjb ^
2888a5e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kch okay, i'll check that out and also do some tests!
2888a5e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I guess this would be a problem in your fork since you're using sane_timeout, which raises in the calling thread.
2888a5e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kch did the heroku branch get merged into master? (the branch seems to be missing but i don't see the merge in the changelog)
2888a5e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2888a5e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh, gotcha!
BTW, to be clear, I NEVER ran my branch in production. It was a side project I hacked on for a few days but didn't have time to get into good enough shape to deploy.