Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation doc #1021

Merged
merged 3 commits into from
May 24, 2022
Merged

Conversation

hannaeko
Copy link
Member

@hannaeko hannaeko commented May 23, 2022

Purpose

  • The current version of JSON Validator on Ubuntu is up to date, the note no longer applies.
  • Some build dependencies are missing.

Context

-

Changes

  • Remove JSON Validator note in Ubuntu installation
  • Add Test::Difference and Test::Exception to the list of test dependencies

How to test this PR

Installation should work.

@hannaeko hannaeko added this to the v2022.1 milestone May 23, 2022
@hannaeko hannaeko requested review from mattias-p, matsduf and a user May 23, 2022 07:22
@hannaeko hannaeko changed the title Remove note for ubuntu install Update installation doc May 23, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version of JSON Validator on Ubuntu is up to date, the note no longer applies.

I understand that we require a minimum version of JSON::Validator. Currently it is set to 4.00 in Makefile.PL. Is this version unsupported? Maybe update the minimum required version there.

@hannaeko
Copy link
Member Author

Version 4.00 is required, it is the current version in Debian 11, but was not available on Ubuntu 20.04. Now that we upgraded the supported version of Ubuntu to 22.04, we can use the one in the official repository (5.0), no need to update the minimum version in Makefile.PL.

mattias-p
mattias-p previously approved these changes May 23, 2022
Copy link
Member

@mattias-p mattias-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mattias-p mattias-p mentioned this pull request May 23, 2022
@matsduf
Copy link
Contributor

matsduf commented May 23, 2022

Can you add p5-Test-Differences and p5-Test-Exception to FreeBSD?

@hannaeko
Copy link
Member Author

Can you add p5-Test-Differences and p5-Test-Exception to FreeBSD?

Done

@hannaeko hannaeko merged commit c4996e4 into zonemaster:develop May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants