Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate config section for each db engine #719

Closed
mattias-p opened this issue Mar 16, 2021 · 3 comments
Closed

Separate config section for each db engine #719

mattias-p opened this issue Mar 16, 2021 · 3 comments
Milestone

Comments

@mattias-p
Copy link
Member

mattias-p commented Mar 16, 2021

Today all supported database engines are configured using the same properties in the same section of the backend_config ini file. If you have multiple database engines installed and want to switch between them you need to either update multiple properties in your config to make the switch, or you need to have several config files differing only in the database details. This adds an unnecessary hoop you have to jump through in all sorts of testing related contexts. Also this overloading of properties makes the configuration format documentation more opaque to the reader.

The configuration format should be updated to have a separate section for each supported database engine.
The Config module should support overriding the database engine type programmatically. (This would come in handy for unit tests at the very least.)

The old properties should be deprecated, their semantics should be updated so that they work as fallbacks for the properties in all of the database engine-specific sections. The deprecation message should instruct the user to use the corresponding database specific property instead.

@matsduf matsduf added this to the v2021.2 milestone Mar 16, 2021
@matsduf
Copy link
Contributor

matsduf commented Mar 16, 2021

I think it is a good idea to have separate sections for the different database engines, but do we really gain enough from making it possible to select engine on the command line? I think that should still be in the configuration file only.

@mattias-p
Copy link
Member Author

mattias-p commented Mar 17, 2021

Maybe not. I removed that requirement. If we change our minds we can always add it later.

@mattias-p
Copy link
Member Author

Fixed by #730.

@mattias-p mattias-p modified the milestones: v2021.2, v2021.1 May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants