Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove value judgements from test case messages #1014

Open
mattias-p opened this issue Nov 24, 2021 · 1 comment
Open

Remove value judgements from test case messages #1014

mattias-p opened this issue Nov 24, 2021 · 1 comment
Labels
A-TestCase Area: Test case specification or implementation of test case
Milestone

Comments

@mattias-p
Copy link
Member

mattias-p commented Nov 24, 2021

Today we have few test case messages that include value judgements such as "Unexpectedly ..." and "which is not OK". Test case messages should plainly state facts. Value judgements should instead be conveyed by the severity level assigned to the message. In DNSCheck we had longer explanations of the test messages. Unfortunately we don't have such explanations in Zonemaster, but if we did that would be a good place for a more nuanced description of the severity.

@matsduf matsduf added this to the v2022.1 milestone Nov 24, 2021
@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label Nov 24, 2021
@matsduf
Copy link
Contributor

matsduf commented Nov 24, 2021

Since we tend to specify more into the specifications the issue should maybe be as zonemaster/zonemaster issue.

Should the test case specification template be updated?

It would also be helpful if this issue lists those messages (message tags) that are in question.

@matsduf matsduf modified the milestones: v2022.1, v2022.2 May 21, 2022
@matsduf matsduf modified the milestones: v2022.2, v2023.1 Dec 20, 2022
@matsduf matsduf modified the milestones: v2023.1, v2023.2 Jun 26, 2023
@matsduf matsduf modified the milestones: v2023.2, v2024.1 Mar 19, 2024
@matsduf matsduf modified the milestones: v2024.1, v2024.2 Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-TestCase Area: Test case specification or implementation of test case
Projects
None yet
Development

No branches or pull requests

2 participants