Delegation02 delegation checks #400
Conversation
Fake delegation lookups are done without trailing dots, so they must be stored that way as well.
t/Test-delegation02-A.t
Outdated
| ok( !$res{CHILD_NS_SAME_IP}, q{should not emit CHILD_NS_SAME_IP} ); | ||
| ok( $res{DEL_DISTINCT_NS_IP}, q{should emit DEL_DISTINCE_NS_IP} ); |
There was a problem hiding this comment.
"should emit DEL_DISTINCE_NS_IP" => "should emit DEL_DISTINCT_NS_IP"
t/Test-delegation02-A.t
Outdated
| ok( !$res{CHILD_NS_SAME_IP}, q{should not emit CHILD_NS_SAME_IP} ); | ||
| ok( $res{DEL_DISTINCT_NS_IP}, q{should emit DEL_DISTINCE_NS_IP} ); | ||
| ok( $res{CHILD_DISTINCT_NS_IP}, q{should emit CHILD_DISTINCE_NS_IP} ); |
There was a problem hiding this comment.
"should emit CHILD_DISTINCE_NS_IP" => "should emit CHILD_DISTINCT_NS_IP"
| 'ns1.b.delegation02.exempelvis.se' => [ '46.21.97.97', '2a02:750:12:77::97' ], | ||
| 'ns2.b.delegation02.exempelvis.se' => [ '46.21.97.97', '2a02:750:12:77::97' ], | ||
| }, | ||
| ); |
There was a problem hiding this comment.
Why add that as undelegated instead of letting Zonemaster pick live data up?
There was a problem hiding this comment.
Mostly because it reflects our use case. I guess it's not necessary. However, doing that is what unveiled the trailing dots problem.
t/Test-delegation02-C.t
Outdated
| ok( $res{CHILD_NS_SAME_IP}, q{should emit CHILD_NS_SAME_IP} ); | ||
| ok( $res{DEL_DISTINCT_NS_IP}, q{should emit DEL_DISTINCE_NS_IP} ); |
There was a problem hiding this comment.
"should emit CHILD_DISTINCE_NS_IP" => "should emit CHILD_DISTINCT_NS_IP"
t/Test-delegation02-B.t
Outdated
| ok( !$res{CHILD_NS_SAME_IP}, q{should not emit CHILD_NS_SAME_IP} ); | ||
| ok( !$res{DEL_DISTINCT_NS_IP}, q{should not emit DEL_DISTINCE_NS_IP} ); | ||
| ok( $res{CHILD_DISTINCT_NS_IP}, q{should emit CHILD_DISTINCE_NS_IP} ); | ||
|
|
There was a problem hiding this comment.
"should emit CHILD_DISTINCE_NS_IP" => "should emit CHILD_DISTINCT_NS_IP"
t/Test-delegation02-D.t
Outdated
| ok( $res{DEL_NS_SAME_IP}, q{should emit DEL_NS_SAME_IP} ); | ||
| ok( $res{CHILD_NS_SAME_IP}, q{should emit CHILD_NS_SAME_IP} ); | ||
| ok( !$res{DEL_DISTINCT_NS_IP}, q{should not emit DEL_DISTINCE_NS_IP} ); | ||
| ok( !$res{CHILD_DISTINCT_NS_IP}, q{should not emit CHILD_DISTINCE_NS_IP} ); |
There was a problem hiding this comment.
"should not emit DEL_DISTINCE_NS_IP" => "should not emit DEL_DISTINCT_NS_IP"
"should emit CHILD_DISTINCE_NS_IP" => "should emit CHILD_DISTINCT_NS_IP"
This adds a new check/message to Delegation02.
Final part of implementating zonemaster/zonemaster#610.
This also fixes a problem where fake delegations were stored and looked up differently.