Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that a signed zone include a DNSKEY for each algorithm present in the zone's DS RRset #528

Closed
matsduf opened this issue Nov 16, 2017 · 5 comments
Assignees
Labels
A-TestCase Area: Test case specification or implementation of test case P-High Priority: Issue to be solved before other
Milestone

Comments

@matsduf
Copy link
Contributor

matsduf commented Nov 16, 2017

From RFC 6840:

  The DS RRset and DNSKEY RRset are used to signal which algorithms
  are used to sign a zone.  The presence of an algorithm in either a
  zone's DS or DNSKEY RRset signals that that algorithm is used to
  sign the entire zone.

  A signed zone MUST include a DNSKEY for each algorithm present in
  the zone's DS RRset and expected trust anchors for the zone.  The
  zone MUST also be signed with each algorithm (though not each key)
  present in the DNSKEY RRset.  It is possible to add algorithms at
  the DNSKEY that aren't in the DS record, but not vice versa.  If
  more than one key of the same algorithm is in the DNSKEY RRset, it
  is sufficient to sign each RRset with any subset of these DNSKEYs.
  It is acceptable to sign some RRsets with one subset of keys (or
  key) and other RRsets with a different subset, so long as at least
  one DNSKEY of each algorithm is used to sign each RRset.
  Likewise, if there are DS records for multiple keys of the same
  algorithm, any subset of those may appear in the DNSKEY RRset.

Create a new Test Case that requires that for each algorithm found in the DS RRset for the zone, there is also a DNSKEY with the same algorithm.

@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label Nov 16, 2017
@pawal
Copy link
Contributor

pawal commented Nov 16, 2017

Also see #344

@sandoche2k sandoche2k added this to the 2018.1 milestone Nov 22, 2017
@matsduf
Copy link
Contributor Author

matsduf commented Nov 28, 2017

Replaces #527

@sandoche2k sandoche2k modified the milestones: v2018.1, v2018.2 Apr 13, 2018
@sandoche2k sandoche2k modified the milestones: v2018.2, v2019.2 Jun 19, 2019
@sandoche2k sandoche2k added the P-High Priority: Issue to be solved before other label Jun 19, 2019
@sandoche2k
Copy link
Contributor

@matsduf @pawal
As I understand: https://github.com/zonemaster/zonemaster/blob/master/docs/specifications/tests/DNSSEC-TP/dnssec02.md matches all DS RR algorithm with DNSKEY RR from the child

If we add the same to https://github.com/zonemaster/zonemaster/blob/master/docs/specifications/tests/DNSSEC-TP/dnssec07.md

then this issue could be resolved. Isn't it?

@matsduf
Copy link
Contributor Author

matsduf commented Jun 28, 2019

PR #782 will solve this issue.

@matsduf
Copy link
Contributor Author

matsduf commented Oct 10, 2019

Resolved by #782.

@matsduf matsduf closed this as completed Oct 10, 2019
tgreenx pushed a commit to tgreenx/zonemaster that referenced this issue Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-TestCase Area: Test case specification or implementation of test case P-High Priority: Issue to be solved before other
Projects
None yet
Development

No branches or pull requests

3 participants