Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated DNSSEC02 #782

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Updated DNSSEC02 #782

merged 2 commits into from
Oct 8, 2019

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Jun 28, 2019 •
edited

  • Transformed into new format.
  • Explicit messages in specification.
  • Changed, added and removed messages.
  • Logic updated:
    • All DS must match DNSKEY.
    • DS is validated against DNSKEY.
    • DNSKEY of DS must have signed DNSKEY RRset.
    • RRSIG is validated against DNSKEY.
    • DNSKEY is check for Zone key flag and SEP flag, respectively.

This PR will solve #528 and #344.

When this PR has been merged an issue will be created in Zonemaster-Engine.

@matsduf
Updated DNSSEC02
44218f4 
* Transformed into new format.
* Explicit messages in specification.
* Changed, added and removed messages.
* Logic updated:
  * All DS must match DNSKEY.
  * DS is validated against DNSKEY.
  * DNSKEY of DS must have signed DNSKEY RRset.
  * RRSIG is validated against DNSKEY.
@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label Jun 28, 2019
@matsduf matsduf added this to the v2019.2 milestone Jun 28, 2019
This was referenced Jun 28, 2019
Closed
Closed
Open
@matsduf
Added test for SEP flag.
9531efe 
Some editorial updates.
@matsduf
Copy link
Contributor Author

matsduf commented Sep 20, 2019

Waiting for the review of @vlevigneron.

@matsduf matsduf merged commit d6aa5d5 into zonemaster:develop Oct 8, 2019
@matsduf matsduf mentioned this pull request Oct 8, 2019
Closed
@matsduf matsduf deleted the update-dnssec02 branch October 8, 2019 15:59
@matsduf
Copy link
Contributor Author

matsduf commented Oct 8, 2019

Issue zonemaster/zonemaster-engine#619 has been created for the update.

tgreenx pushed a commit to tgreenx/zonemaster that referenced this pull request Jan 3, 2022
@matsduf
Merge pull request zonemaster#782 from matsduf/fix-no-soa
39b5d51 
"Fix NO_SOA_IN_RESPONSE message" to correct branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandoche2k sandoche2k sandoche2k approved these changes

@vlevigneron vlevigneron vlevigneron approved these changes

@mattias-p mattias-p Awaiting requested review from mattias-p

Assignees
No one assigned
Labels
A-TestCase Area: Test case specification or implementation of test case
Projects
None yet
Milestone
v2019.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matsduf @sandoche2k @vlevigneron