-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates algortithm table in DNSSEC05 specification #1183
Conversation
@tgreenx and @marc-vanderwal, the Zonemaster defined mnemonics in this PR are lower case, while the IANA defined are in upper case. Should I change to upper case? |
If “reserved” and the other mnemonics are kept as lowercase, DS10_ALGO_NOT_SUPPORTED_BY_ZM would be rendered as:
If switching to uppercase, that would be:
I think the lowercase form looks best. |
@marc-vanderwal, what I meant was all uppercase, e.g.
The IANA defined mnemonics are in all uppercase. Let us say that Gost is not supported, then the same message will be today:
I think that the Zonemaster defined mnemonics should follow the same pattern as the IANA defined mnemonics, i.e. be in all uppercase. |
You’re right, the all-uppercase versions actually look better. I’m fine with this change. |
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
@marc-vanderwal and @tgreenx, please re-review. |
Purpose
Zonemaster needs DNSKEY algorithm mnemonic for all possible algorithms. The IANA table has no mnemonic for resevered or unassigned algorithms. The purpose of this PR is to let this test case defined such mnemonics for the use in Zonemaster implementation of any test case needing it.
This PR does not update any other parts of the specification even though it does not fully match the current test case specification template. That is for another PR.
Context
See #1179 (comment) and the responses on that.
This PR makes this specification authoritative of the table above, which means that Argument list must be updated (to-do).
Changes
This PR does not change any logic and requires not updates to the implementation of the test case.
How to test this PR
Review the changes.