Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates algortithm table in DNSSEC05 specification #1183

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Jul 25, 2023

Purpose

Zonemaster needs DNSKEY algorithm mnemonic for all possible algorithms. The IANA table has no mnemonic for resevered or unassigned algorithms. The purpose of this PR is to let this test case defined such mnemonics for the use in Zonemaster implementation of any test case needing it.

This PR does not update any other parts of the specification even though it does not fully match the current test case specification template. That is for another PR.

Context

See #1179 (comment) and the responses on that.

This PR makes this specification authoritative of the table above, which means that Argument list must be updated (to-do).

Changes

This PR does not change any logic and requires not updates to the implementation of the test case.

How to test this PR

Review the changes.

@matsduf matsduf added A-TestCase Area: Test case specification or implementation of test case A-Documentation Area: Documentation only. labels Jul 25, 2023
@matsduf matsduf added this to the v2023.2 milestone Jul 25, 2023
tgreenx
tgreenx previously approved these changes Jul 25, 2023
marc-vanderwal
marc-vanderwal previously approved these changes Aug 16, 2023
@matsduf
Copy link
Contributor Author

matsduf commented Aug 16, 2023

@tgreenx and @marc-vanderwal, the Zonemaster defined mnemonics in this PR are lower case, while the IANA defined are in upper case. Should I change to upper case?

@marc-vanderwal
Copy link
Contributor

@tgreenx and @marc-vanderwal, the Zonemaster defined mnemonics in this PR are lower case, while the IANA defined are in upper case. Should I change to upper case?

If “reserved” and the other mnemonics are kept as lowercase, DS10_ALGO_NOT_SUPPORTED_BY_ZM would be rendered as:

DNSKEY with tag 51966 uses unsupported algorithm 123 (reserved) by this installation of Zonemaster. Fetched from the nameservers with IP addresses "ns.example/2001:db8:8::53".

If switching to uppercase, that would be:

DNSKEY with tag 51966 uses unsupported algorithm 123 (Reserved) by this installation of Zonemaster. Fetched from the nameservers with IP addresses "ns.example/2001:db8:8::53".

I think the lowercase form looks best.

@matsduf
Copy link
Contributor Author

matsduf commented Aug 22, 2023

@marc-vanderwal, what I meant was all uppercase, e.g.

DNSKEY with tag 51966 uses unsupported algorithm 123 (RESERVED) by this installation of Zonemaster. Fetched from the nameservers with IP addresses "ns.example/2001:db8:8::53".

The IANA defined mnemonics are in all uppercase. Let us say that Gost is not supported, then the same message will be today:

DNSKEY with tag 51966 uses unsupported algorithm 12 (ECC-GOST) by this installation of Zonemaster. Fetched from the nameservers with IP addresses "ns.example/2001:db8:8::53".

I think that the Zonemaster defined mnemonics should follow the same pattern as the IANA defined mnemonics, i.e. be in all uppercase.

@marc-vanderwal
Copy link
Contributor

You’re right, the all-uppercase versions actually look better. I’m fine with this change.

marc-vanderwal
marc-vanderwal previously approved these changes Aug 22, 2023
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
@matsduf
Copy link
Contributor Author

matsduf commented Nov 22, 2023

@marc-vanderwal and @tgreenx, please re-review.

@matsduf matsduf merged commit d40c08c into zonemaster:develop Dec 4, 2023
@matsduf matsduf deleted the update-dnssec05 branch December 4, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Documentation Area: Documentation only. A-TestCase Area: Test case specification or implementation of test case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants