Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move and update Arguments document #1190

Merged
merged 6 commits into from
Nov 18, 2023

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Jul 30, 2023

Purpose

The Arguments document resided in the Zonemaster-Engine repository, but is usually updated when updating test case specifications. All references are from this repository.

This PR also adds a new name used in #1189.

This PR also updates the reference to the DNSSEC algorithms as specified in #1183 and expected by #1179.

When this PR is merged, the document should be removed in the Zonemaster-Engine repository. See zonemaster/zonemaster-engine#1268.

Changes

The changes are found the following commits:

  1. Copies the document verbatim from Zonemaster-Engine.
  2. Adds the new argument name ("int").
  3. Changes the DNSSEC algorithm reference.
  4. Updates all documents that has a reference to the Arguments document to point at the new location.
  5. Updates links that assumed that the document was still in the Zonemaster-Engine repository.

How to test this PR

Review and check links. Note there is a link to DNSSEC05 that assumes that is has been updated by #1183.

Copy link
Contributor

@tgreenx tgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos otherwise LGTM

Copy link
Contributor Author

@matsduf matsduf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgreenx, thanks for reviewing!

@matsduf matsduf merged commit 866f89b into zonemaster:develop Nov 18, 2023
@matsduf matsduf deleted the move-argument-name-doc-here branch November 18, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Documentation Area: Documentation only.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants