-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move and update Arguments document #1190
Merged
matsduf
merged 6 commits into
zonemaster:develop
from
matsduf:move-argument-name-doc-here
Nov 18, 2023
Merged
Move and update Arguments document #1190
matsduf
merged 6 commits into
zonemaster:develop
from
matsduf:move-argument-name-doc-here
Nov 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsduf
requested review from
mattias-p,
hannaeko,
a user,
tgreenx and
marc-vanderwal
July 30, 2023 17:12
tgreenx
reviewed
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few typos otherwise LGTM
docs/public/specifications/tests/ArgumentsForTestCaseMessages.md
Outdated
Show resolved
Hide resolved
docs/public/specifications/tests/ArgumentsForTestCaseMessages.md
Outdated
Show resolved
Hide resolved
matsduf
commented
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tgreenx, thanks for reviewing!
docs/public/specifications/tests/ArgumentsForTestCaseMessages.md
Outdated
Show resolved
Hide resolved
docs/public/specifications/tests/ArgumentsForTestCaseMessages.md
Outdated
Show resolved
Hide resolved
marc-vanderwal
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The Arguments document resided in the Zonemaster-Engine repository, but is usually updated when updating test case specifications. All references are from this repository.
This PR also adds a new name used in #1189.
This PR also updates the reference to the DNSSEC algorithms as specified in #1183 and expected by #1179.
When this PR is merged, the document should be removed in the Zonemaster-Engine repository. See zonemaster/zonemaster-engine#1268.
Changes
The changes are found the following commits:
How to test this PR
Review and check links. Note there is a link to DNSSEC05 that assumes that is has been updated by #1183.