-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates NAMESERVER15 #1199
Updates NAMESERVER15 #1199
Conversation
@tgreenx, you wrote the specification. Please review this proposal of updates. |
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
* Adds test for class on the TXT records * Remove check of owner name of TXT records * Editorial update
14c3aff
@tgreenx and @marc-vanderwal, please re-review. |
Co-authored-by: tgreenx <96772376+tgreenx@users.noreply.github.com>
@marc-vanderwal, are you also fine with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that looks good to me!
Test zone specification for this test case in #1217 |
…from version string
@tgreenx and @marc-vanderwal, I made a version string just consisting of space to be equal to empty version string. |
Now the test zones have been implemented. |
@tgreenx, you did the current implementation of Nameserver15. Could you do the update? |
Yes |
Follows test specification update (zonemaster/zonemaster#1199). Unit tests and data are also updated, based on zonemaster/zonemaster#1217.
A trivial merge conflict was resolved after two approvals. Merge without waiting for renewed approval. |
Purpose
The objective of the test case states about name servers that "it may sometimes be desirable not to reveal that information" but then if it does, this test case only sends an INFO message. An INFO message does not signal that there is any reason to look at it. This PR raises the level to NOTICE.
The specification does not distinguish between a server that does not respond at all on a "version query" and a server that responds, but with no version information. In the following example some of the servers do not respond at all and some of them responds with no information. This PR splits the message and make the test case make a distinction.
This PR also make the test case skip servers that do not even answer SOA queries to make it lift up any servers that do not answer because it is a "version query".
This PR also changes the argument from
ns_ip_list
tons_list
to give more information. It uses the same technique introduced by #1179.This PR also updates the test case to check the class in the response.
Context
Also see zonemaster/zonemaster-engine#1281
Also see #1208
Also see test zones that match this update in #1217.
Changes
The specification of NAMESERVER15.
How to test this PR
Review the proposed changes.