Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specification of test zones and test zones for NAMESERVER15 #1217

Merged
merged 11 commits into from
Nov 20, 2023
Merged

Specification of test zones and test zones for NAMESERVER15 #1217

merged 11 commits into from
Nov 20, 2023

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Oct 19, 2023 •
edited
Loading

Purpose

  • Specification of test zones for Nameserver15
  • Test zones are included.
  • The address plan for the test environment has been rewritten in a new format.
  • Instructions for compiling CoreDNS has been updated to gain support for CHAOS queries.

Context

Matches NAMESERVER15 as updated in #1199. Test zones covers all message tags in various scenarios.

How to test this PR

  • Review the definitions of the scenarios.
  • Create a server with the test zone environment. Make sure to follow the updated instructions to get support for CHAOS queries required by this test case.
  • Verify the test zones with dig. Optionally verify against Nameserver15 before update with the help of zonemaster-clion the test server.
  • Match against updated Nameserver15 with the help of zonemaster-cli.

@matsduf matsduf added this to the v2023.2 milestone Oct 19, 2023
@matsduf matsduf mentioned this pull request Oct 19, 2023
Merged
@matsduf matsduf marked this pull request as draft October 20, 2023 10:58
@matsduf matsduf force-pushed the create-test-zone-spec-nameserver15 branch from 61dfb0c to 9f2026c Compare October 27, 2023 13:31
@matsduf matsduf marked this pull request as ready for review October 27, 2023 21:15
@matsduf matsduf changed the title Specification of test zones for NAMESERVER15 Specification of test zones and test zones for NAMESERVER15 Nov 2, 2023
@matsduf matsduf force-pushed the create-test-zone-spec-nameserver15 branch from 7df3412 to 579c636 Compare November 5, 2023 13:53
tgreenx
tgreenx reviewed Nov 16, 2023
View reviewed changes
docs/public/specifications/test-zones/Nameserver-TP/nameserver15.md Outdated
Comment on lines 53 to 54
ERROR-ON-VERSION-QUERY-1 | N15_ERROR_ON_VERSION_QUERY | N15_NO_VERSION_REVEALED, N15_SOFTWARE_VERSION, N15_WRONG_CLASS
ERROR-ON-VERSION-QUERY-2 | N15_ERROR_ON_VERSION_QUERY | N15_NO_VERSION_REVEALED, N15_SOFTWARE_VERSION, N15_WRONG_CLASS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those two scenarios, I think N15_NO_VERSION_REVEALED should be outputted in both cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, as the test case specification is written. When I updated the test case specification I think my idea was not to output N15_NO_VERSION_REVEALED when N15_ERROR_ON_VERSION_QUERY was outputted. I guess either way could be fine, so lets keep it as it is. I will update the scenarios.

tgreenx added a commit to tgreenx/zonemaster-engine that referenced this pull request Nov 16, 2023
@tgreenx
Update implementation of Nameserver15
f4af7a2 
Follows test specification update (zonemaster/zonemaster#1199).

Unit tests and data are also updated, based on zonemaster/zonemaster#1217.
@tgreenx tgreenx mentioned this pull request Nov 16, 2023
Merged
@matsduf
Copy link
Contributor Author

matsduf commented Nov 19, 2023

@tgreenx, please re-review. The two scenarios you had comment on have been corrected. See the logs in https://github.com/zonemaster/zonemaster/pull/1217/files#diff-fa899e4a065b006382f21973481f6aa0b39d9b5e71f2029cc6d76c1b0cd77aa7

@matsduf matsduf requested a review from tgreenx November 19, 2023 22:36
tgreenx
tgreenx approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@tgreenx tgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I suggest the change from add-ip.sh to set-ip.sh is done in a PR of its own.

@matsduf
Copy link
Contributor Author

matsduf commented Nov 20, 2023

LGTM but I suggest the change from add-ip.sh to set-ip.sh is done in a PR of its own.

I plan to handle the conflict when it comes.

@matsduf matsduf merged commit 3c7346a into zonemaster:develop Nov 20, 2023
@matsduf matsduf deleted the create-test-zone-spec-nameserver15 branch November 20, 2023 11:42
marc-vanderwal pushed a commit to marc-vanderwal/zonemaster that referenced this pull request Nov 21, 2023
Update Zonemaster-Engine installation document
64e2e46 
Latest update from develop, commit
32a6d998da8bc09fdb85333e4080f725f3028671

* Disables testing in installation instructions zonemaster#1217 (@matsduf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgreenx tgreenx tgreenx approved these changes

@mattias-p mattias-p Awaiting requested review from mattias-p

@hannaeko hannaeko Awaiting requested review from hannaeko

@marc-vanderwal marc-vanderwal Awaiting requested review from marc-vanderwal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2023.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matsduf @tgreenx