Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates DNSSEC specifications to lower level of no response #952

Merged
merged 2 commits into from
May 26, 2021

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented May 25, 2021

BASIC04 has been implemented to report on problem with responses from nameservers. The DNSSEC specifications and their implementation, repeats reporting the same thing with no benefit. With this PR the Consistency test case will refer that to BASIC04.

A PR to lower the level in the profile will be created in Zonemaster-Engine (zonemaster/zonemaster-engine#923).

  • Adds reference to BASIC04, which tests all name servers for non-response.
  • Lower default level to DEBUG for messages that report on non-response.
  • DNSSEC14 has not been updated. See discussion in Nameserver14 is not implemented zonemaster-engine#920
  • DNSSEC14 is included.

Relates to #950 and #951

mattias-p
mattias-p previously approved these changes May 26, 2021
* Adds reference to BASIC04, which tests all name servers for non-response.
* Lower default level to DEBUG for messages that report on non-response.
* DNSSEC14 has not been updated.
@matsduf
Copy link
Contributor Author

matsduf commented May 26, 2021

@mattias-p, please re-review.

mattias-p
mattias-p previously approved these changes May 26, 2021
Copy link
Member

@mattias-p mattias-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized there's a broken link to DNSSEC05 in DNSSEC14. That problem wasn't introduced in this PR, but rather it was present before.

@mattias-p mattias-p dismissed their stale review May 26, 2021 14:56

I noticed a broken link.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @mattias-p
I approve the PR in case you prefer to open a new PR for the broken link in dnssec14.md.

@matsduf
Copy link
Contributor Author

matsduf commented May 26, 2021

Yes, I will fix the link in a new PR.

@matsduf matsduf merged commit 2f7a3c8 into zonemaster:develop May 26, 2021
@matsduf matsduf deleted the dnssec-lower-no-response branch May 26, 2021 17:48
tgreenx pushed a commit to tgreenx/zonemaster that referenced this pull request Jan 3, 2022
…er-engine-948

- Fixes fatal error in output for basic04 test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-TestCase Area: Test case specification or implementation of test case P-High Priority: Issue to be solved before other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants