Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Zone10 specifications to lower level of no response #955

Merged
merged 3 commits into from
May 26, 2021

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented May 25, 2021

BASIC04 has been implemented to report on problem with responses from nameservers. The Zone10 specification and its implementation, repeats reporting the same thing with no benefit. With this PR the Zone10 test case will refer that to BASIC04.

A PR to lower the level in the profile is created in Zonemaster-Engine (zonemaster/zonemaster-engine#923).

  • Adds reference to BASIC04, which tests all name servers for non-response.
  • Lower default level to DEBUG for messages that report on non-response.

This PR relates to #950, #951, #952, #953, #954

* Adds reference to BASIC04, which tests all name servers for non-response.
* Lower default level to DEBUG for messages that report on non-response.
@matsduf matsduf added A-TestCase Area: Test case specification or implementation of test case P-High Priority: Issue to be solved before other labels May 25, 2021
@matsduf matsduf added this to the v2021.1 milestone May 25, 2021
@matsduf matsduf requested review from mattias-p and a user May 25, 2021 12:52
Copy link
Member

@mattias-p mattias-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels a bit like all of Zone10 should be deprecated and replaced by Basic04. (With Basic04 being extended to cover the remaining messages in Zone10.)

NO_RESPONSE | WARNING
NO_SOA_IN_RESPONSE | WARNING
NO_RESPONSE | DEBUG
NO_SOA_IN_RESPONSE | DEBUG
ONE_SOA | INFO
WRONG_SOA | ERROR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't WRONG_SOA also be demoted to DEBUG?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Will fix.

@mattias-p
Copy link
Member

Oh, and maybe the title should be fixed as well: multipe -> multiple.

mattias-p
mattias-p previously approved these changes May 26, 2021
@matsduf matsduf merged commit 923979b into zonemaster:develop May 26, 2021
@matsduf matsduf deleted the zone-lower-no-response branch May 26, 2021 18:15
tgreenx pushed a commit to tgreenx/zonemaster that referenced this pull request Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-TestCase Area: Test case specification or implementation of test case P-High Priority: Issue to be solved before other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants