-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates Zone10 specifications to lower level of no response #955
Conversation
* Adds reference to BASIC04, which tests all name servers for non-response. * Lower default level to DEBUG for messages that report on non-response.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels a bit like all of Zone10 should be deprecated and replaced by Basic04. (With Basic04 being extended to cover the remaining messages in Zone10.)
NO_RESPONSE | WARNING | ||
NO_SOA_IN_RESPONSE | WARNING | ||
NO_RESPONSE | DEBUG | ||
NO_SOA_IN_RESPONSE | DEBUG | ||
ONE_SOA | INFO | ||
WRONG_SOA | ERROR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't WRONG_SOA also be demoted to DEBUG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Will fix.
Oh, and maybe the title should be fixed as well: |
BASIC04 has been implemented to report on problem with responses from nameservers. The Zone10 specification and its implementation, repeats reporting the same thing with no benefit. With this PR the Zone10 test case will refer that to BASIC04.
A PR to lower the level in the profile is created in Zonemaster-Engine (zonemaster/zonemaster-engine#923).
This PR relates to #950, #951, #952, #953, #954