Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core-js should be a dependency #28

Closed
bpierre opened this issue Apr 5, 2021 · 1 comment
Closed

core-js should be a dependency #28

bpierre opened this issue Apr 5, 2021 · 1 comment

Comments

@bpierre
Copy link

bpierre commented Apr 5, 2021

core-js is set as a devDependency, but it is being imported at runtime.

Moving it to the dependencies should fix the issue.
@bpierre bpierre mentioned this issue Apr 5, 2021
Open
@rafgraph rafgraph mentioned this issue Apr 6, 2021
Open
rafgraph added a commit to rafgraph/rollpkg that referenced this issue Apr 6, 2021
@rafgraph
Add core-js as dependency as a temporary fix
d61ed9b 
Temporary fix for: #6
Which is caused by: pastelsky/package-build-stats#37
Which is caused by: zoobestik/csso-webpack-plugin#28
zoobestik added a commit that referenced this issue Apr 9, 2021
@zoobestik
Move core-js from dev to runtime dependencies (closes #28, #29)
cc08296
@zoobestik zoobestik mentioned this issue Apr 9, 2021
Closed
@zoobestik
Copy link
Owner

Thanks for report!
Fixed in 2.0.0-beta.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpierre @zoobestik