Add group_member_post.go #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-H-GAMELINKS
force-pushed
the
add_group_member_post
branch
from
33dd306
to
cb31ee0
Compare
rafecolton
reviewed
Apr 12, 2021
rafecolton
reviewed
Apr 12, 2021
|
Looks like you have some minor formatting issues as well. This is almost there though, thanks for submitting! |
rafecolton
reviewed
Apr 12, 2021
rafecolton
reviewed
Apr 12, 2021
rafecolton
reviewed
Apr 12, 2021
member_type.go
Outdated
Comment on lines
3
to
14
| // Member represents an group member | ||
| type Member struct { | ||
| ID string `json:"id"` | ||
| Email string `json:"email"` | ||
| } | ||
|
|
||
| // ResopnseAddGroupMembers represents response for added member to group | ||
| type ResopnseAddGroupMembers struct { | ||
| // IDs has comma-delimited, like 'xxxxxxxxxx,xxxxxxxxxx' | ||
| IDs string `json:"ids"` | ||
| AddedAt string `json:"added_at"` | ||
| } |
There was a problem hiding this comment.
Are either of these types used in other API calls? If so, they can remain in this separate file, but if not, let's move them into group_member_post.go
There was a problem hiding this comment.
No used, I'll move to group_member_post.go
rafecolton
previously approved these changes
Apr 12, 2021
|
Looks like your commits are not signed. Can you please sign your commits, and then I will merge? |
S-H-GAMELINKS
force-pushed
the
add_group_member_post
branch
from
08410fc
to
73b88a5
Compare
|
OK, signed commit pushed |
rafecolton
approved these changes
Apr 12, 2021
|
Thanks for marged! |
|
You're welcome, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Thanks for this great library.
I added support for the following Group APIs:
Inaddtional, add group member exsample.