Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text docs #389

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Update text docs #389

merged 2 commits into from
Dec 10, 2020

Conversation

CKrawczyk
Copy link
Collaborator

Add documentation for minimum_views value on the transcription reducers. This value is passed along to the front-end and has no effect on the reduction results. I think any further documentation for how the front-end uses this value should belong with the front-end code so can stay up to date if it ever changes.

Happy to link to the documentation from here if a link exists.

Closes #387

Add documentation for `minimum_views` value on the transription reducers.  This value is passed along to the fron-end and has no effect on the reduction results.  I think any further documentation for how the front-end uses this value should belong with the front-end code so can stay up to date if it ever changes.

Happy to link to the documenation from here if a link exists.
There wre a few places where `---` did not extend fare enough.  Python's doc string syntax can be a bit verbose at times...
Copy link
Member

@lcjohnso lcjohnso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great; this minimal description is enough for the purposes of the aggregation docs, but at least highlights that the parameter exists, is set through the call to the reducer, and is passed along to the FE via the parameters blob. Thanks!

@CKrawczyk CKrawczyk merged commit 4701481 into master Dec 10, 2020
@CKrawczyk CKrawczyk deleted the update-text-docs branch December 10, 2020 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add minimum_views param to docs for optics_line_text_reducer
2 participants