LCV: fix the sameSubject test

Pass `subjectID` so that we can test whether the subject has changed.
zooniverse · Feb 11, 2022 · 38d6cf1 · 38d6cf1
1 parent 93e8697
commit 38d6cf1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/...nents/Classifier/components/SubjectViewer/components/LightCurveViewer/LightCurveViewer.js b/...nents/Classifier/components/SubjectViewer/components/LightCurveViewer/LightCurveViewer.js
@@ -84,14 +84,15 @@ class LightCurveViewer extends Component {
   }
 
   componentDidUpdate (prevProps) {
-    const points = this.props.dataPoints
-    const prevPoints = prevProps.dataPoints
-    const sameSubject = (points === prevPoints)
+    const subject = this.props.subjectID
+    const prevSubject = prevProps.subjectID
+    const sameSubject = (subject === prevSubject)
 
     const currentTaskKey = (this.props.currentTask && this.props.currentTask.taskKey) || ''
     const prevTaskKey = (prevProps.currentTask && prevProps.currentTask.taskKey) || ''
     const sameTask = (currentTaskKey === prevTaskKey)
 
+    console.log({ sameSubject })
     if (!sameSubject) { // Triggers when changing between Subjects
       this.clearChart()
 

diff --git a/...ssifier/components/SubjectViewer/components/LightCurveViewer/LightCurveViewerContainer.js b/...ssifier/components/SubjectViewer/components/LightCurveViewer/LightCurveViewerContainer.js
@@ -114,6 +114,7 @@ export function LightCurveViewerContainer({
       onKeyDown={onKeyDown}
       setOnPan={setOnPan}
       setOnZoom={setOnZoom}
+      subjectID={subject.id}
       toolIndex={activeToolIndex}
     />
   )