Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @inject from subject viewers #2719

Merged
merged 7 commits into from
Feb 15, 2022
Merged

Remove @inject from subject viewers #2719

merged 7 commits into from
Feb 15, 2022

Commits on Feb 11, 2022

  1. Remove @Inject from subject viewers 

    Remove `@inject` from `BarChartViewer`, `LightCurveViewer` and `SubjectGroupViewer`. Convert each from a class to a functional component with hooks.
    @eatyourgreens
    eatyourgreens committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    14adc2a View commit details
    Browse the repository at this point in the history

  2. update tests 

    Try to test rendered output, either `onError` or `onReady`.
    @eatyourgreens
    eatyourgreens committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    cb22e74 View commit details
    Browse the repository at this point in the history

  3. Add useJSONData hook 

    Move common data fetching code into a custom hook for JSON data subjects.
    @eatyourgreens
    eatyourgreens committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    95d99b3 View commit details
    Browse the repository at this point in the history

  4. Update test wording

    @eatyourgreens
    eatyourgreens committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    ac5ca46 View commit details
    Browse the repository at this point in the history

  5. LCV: fix the sameSubject test 

    Pass `subjectID` so that we can test whether the subject has changed.
    @eatyourgreens
    eatyourgreens committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    f10af6d View commit details
    Browse the repository at this point in the history

  6. Fix SGV event handlers 

    Use callbacks to update state from previous state.
    @eatyourgreens
    eatyourgreens committed Feb 11, 2022
    Configuration menu
    Copy the full SHA
    82a7af5 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Merge branch 'master' into remove-inject-subject-viewers

    @eatyourgreens
    eatyourgreens committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    3561c44 View commit details
    Browse the repository at this point in the history