Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for <audio> and <video> #66

Merged
merged 3 commits into from
Mar 9, 2018
Merged

Add support for <audio> and <video> #66

merged 3 commits into from
Mar 9, 2018

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Mar 8, 2018

Adds markdown-it-html5-embed, which allows audio and video files to be embedded by using the standard Markdown image syntax.

Closes #65.

@eatyourgreens
Copy link
Contributor Author

Testing this in conjunction with zooniverse/Panoptes-Front-End#4424 I can't get embedded audio to display. Embedded youtube videos don't seem to work on this branch either, so I'll mark this WIP while I try to figure out what's going on.

@eatyourgreens eatyourgreens changed the title Add support for <audio> and <video> [WIP] Add support for <audio> and <video> Mar 8, 2018
@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Mar 8, 2018

Switching from markdown-it-html5-media to markdown-it-html5-embed seems to fix everything.

@eatyourgreens eatyourgreens changed the title [WIP] Add support for <audio> and <video> Add support for <audio> and <video> Mar 8, 2018
@eatyourgreens
Copy link
Contributor Author

zooniverse/Panoptes-Front-End#4424 is using this version of Markdownz on staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant