Remove subject link to subject set. But keep the subject.

[denys-potapov]

I try to move the subject from one subject set to another. Finding and adding the subject to new subject set works:

origin = SubjectSet.find(origin_id)
destination = SubjectSet.find(destination_id)
subject = Subject.find(subject_id)
destination.add(subject)

Now I see subject in both subject sets. But when i try to unlink the subject from origin. It deletes subject, so it's not visible in both subject_sets:

# this deletes subject
origin.remove(subject)

As i understand, removeng link from subject set to subject should not remove the subject itself?

[PmasonFF]

Checked previous version of panoptes_client 1.03 and reported behavior as above there as well.

Also tried removing redundant .find in above code when referencing a known subject_set.id or subject.id
Also tried to save the destination subject set and/or subject after the .add but this made no difference.

origin.remove(subject) still removed subject from both subject sets, and as far as I can tell subject is deleted (can not be recovered or displayed by subject.id).

I am not sure this is new behaviour or not - I can not recall attempting to move a subject from one subject set where we then removed it from the original subject set.

[adammcmaster]

@camallen Could you weigh in on what the expected behaviour from the API should be? Is the Python client doing something wrong to cause this?

[camallen]

See zooniverse/panoptes#3143

Folks requested the cleanup worker runs when unlinking from sets. Maybe that functionality should check that it's not part of another subject set before removal.