Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added editable attributes to workflow.py allowing editing of workflow #71

Merged
merged 2 commits into from Feb 16, 2017

Conversation

tingard
Copy link
Contributor

@tingard tingard commented Feb 16, 2017

Added ['tasks', 'first_task', 'configuration'] to _edit_attributes in Workflow class in workflow.py

Seems to let you edit workflow objects as expected (tested on panoptes-staging.zooniverse.org)

Copy link
Contributor

@adammcmaster adammcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two small changes that'd be ideal.

  1. Just a small style change, but could you put each attribute on a separate line? It makes it easier to read diffs later on.

  2. Could you add display_name to the list too?

@adammcmaster
Copy link
Contributor

See, e.g., project.py for what I mean in number 1.

@adammcmaster adammcmaster merged commit c4fd645 into zooniverse:master Feb 16, 2017
@adammcmaster
Copy link
Contributor

Thanks! This'll be in the next version, which should hopefully be released next week (depending on #69).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants