Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment touchups #114

Merged
merged 5 commits into from
Jan 25, 2021
Merged

Deployment touchups #114

merged 5 commits into from
Jan 25, 2021

Conversation

zwolf
Copy link
Member

@zwolf zwolf commented Jan 22, 2021 •
edited
Loading

  • Redis needs a persistent volume claim
  • Add the ENV env var so Django needs to know where it is.
  • Update server starter to use above
  • Load the secret key (generated by me via Django console and set in k8s secret as env var) from env var in settings for production

@zwolf zwolf changed the title Add redis pvc & env Deployment touchups Jan 22, 2021
chelseatroy
chelseatroy approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@chelseatroy chelseatroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@zwolf zwolf merged commit 906f7f1 into master Jan 25, 2021
@zwolf zwolf deleted the add-redis-pvc branch January 25, 2021 16:08
@yuenmichelle1 yuenmichelle1 mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chelseatroy chelseatroy chelseatroy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwolf @chelseatroy