Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump swr from 1.3.0 to 2.0.0 #162

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 9, 2022

Bumps swr from 1.3.0 to 2.0.0.

Release notes

Sourced from swr's releases.

2.0.0-rc.3

What's Changed

Full Changelog: vercel/swr@2.0.0-rc.1...2.0.0-rc.3

2.0.0-rc.1

The last RC before SWR 2.0. This release includes several small fixes with one breaking change.

Breaking

In this release, we are dropping IE 11 support, and using ES2018 as the build target. However, when using SWR in a framework or using a bundler (esbuild, Webpack, etc.), you can still target ES5 or using a browserlist configuration to customize this.

The benefit of this change is, we can now use faster native APIs to make SWR more performant, instead of using old alternatives. A benchmark shows a 4.7x speed improvement of the useSWR() function call during SSR, when we change Object.assign({}, a, b) to { ...a, ...b }.

Details can be found in #2249.

What's Changed

New Contributors

Full Changelog: vercel/swr@2.0.0-rc.0...2.0.0-rc.1

2.0.0-rc.0

The SWR 2.0 release candidate. This RC has one breaking change, a new option for mutation APIs, and some bug fixes & improvements.

Highlights & Breakings

A failed mutation will not cause useSWR's error to be updated:

const { error, mutate } = useSWR('/api/user', getUser)
return <button onClick={async () => {
try {
await mutate(updateUser)
} catch (mutationError) {
// mutationError will not cause error to be updated.
}
}}>Update User</button>

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 9, 2022
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/swr-2.0.0 branch from 162e72c to 343cb65 Compare December 9, 2022 18:03
Copy link
Member

@shaunanoordin shaunanoordin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

Rejected, this PR breaks the ability to load aggregations on the Subjects page, e.g.

https://localhost:3000/view/workflow/3438/subject/134548?env=staging results in:

ERROR: Could not fetch Aggregations.
Parse error on "3438" (INT) at [3, 36]: {"response":{"errors":[{"message":"Parse error on \"3438\" (INT) at [3, 36]","locations":[{"line":3,"column":36}]}],"status":200,"headers":{"map":{"cache-control":"max-age=0, private, must-revalidate","content-type":"application/json; charset=utf-8"}}},"request":{"query":"{\n workflow(id: undefined) {\n reductions(subjectId: 134548,3438,,) {\n data\n }\n extracts(subjectId: 134548,3438,,) {\n data\n }\n }\n }"}}

image

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 12, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/swr-2.0.0 branch December 12, 2022 09:27
@eatyourgreens eatyourgreens restored the dependabot/npm_and_yarn/swr-2.0.0 branch December 14, 2022 14:43
@eatyourgreens
Copy link
Contributor

This should work once #164 is merged.

@eatyourgreens eatyourgreens reopened this Dec 14, 2022
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/swr-2.0.0 branch 3 times, most recently from e97d395 to 6133614 Compare December 22, 2022 07:56
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/swr-2.0.0 branch 2 times, most recently from e6a3ba3 to 813008a Compare December 29, 2022 08:35
@eatyourgreens
Copy link
Contributor

@dependabot rebase

Bumps [swr](https://github.com/vercel/swr) from 1.3.0 to 2.0.0.
- [Release notes](https://github.com/vercel/swr/releases)
- [Commits](vercel/swr@1.3.0...2.0.0)

---
updated-dependencies:
- dependency-name: swr
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/swr-2.0.0 branch from 813008a to c3cd452 Compare December 29, 2022 08:43
@eatyourgreens eatyourgreens merged commit a849607 into master Dec 29, 2022
@eatyourgreens eatyourgreens deleted the dependabot/npm_and_yarn/swr-2.0.0 branch December 29, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants