Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loaded modules #411

Open
wants to merge 11 commits into
base: dark_zoon
Choose a base branch
from
Open

Conversation

goldingn
Copy link
Member

Change zoon to load all modules into memory at once when loading zoon.
Modules are maintained in an R package (zoon.modules) which is automatically (with user prompt) installed from CRAN IFF a newer version is available.
This means that LoadModule() isn't needed, ModuleHelp() is redundant since ? and help() can be used, ModuleArguments() is redundant as formals() can be used.

This version downloads the modules repo from the dark_modules branch, but that can be changed.

@timcdlucas
Copy link
Contributor

Do all modules get loaded in global namespace or somewhere else?

@goldingn
Copy link
Member Author

They're attached as a package (so in a namespace which is attached to the search path), which means autocomplete works, you can get helpfiles with ?, and can use zoon offline

@goldingn
Copy link
Member Author

This is running and passing tests fine locally. Just need to resolve this Travis-only issue.

@timcdlucas
Copy link
Contributor

OK, sounds good. Guess we should tryyy a bit not to have mega common module names then. Though going to be hard to enforce on contributed modules.

@goldingn
Copy link
Member Author

Yeah, good point!

BTW we (mainly @smwindecker) are working on another big change which removes all the parsing code from workflow and generally simplifies the internal workings, removes the 'default arguments' from modules (and simplifies their structure), and enables things like having multiple lists in a workflow, and chains within lists.
That will change how modules functions are defined, but keeps the API the same from the module user's perspective.

We'll merge all this stuff together in the dark_zoon branch then we can all discuss how to polish/change that before integrating into master.

@timcdlucas
Copy link
Contributor

Ooh sounds exciting. I'll keep an eye out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants