fix(windows): bump windows WindowsTargetPlatform #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
|
@zoontek Would you mind looking at this PR when you have the chance? :) This will block RNW apps from using version .72 |
|
@TatianaKapos I totally forgot, thanks for the reminder! |
renovate bot
added a commit
to valora-inc/wallet
that referenced
this pull request
Oct 10, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [react-native-permissions](https://togithub.com/zoontek/react-native-permissions) | [`^3.0.3` -> `^3.9.3`](https://renovatebot.com/diffs/npm/react-native-permissions/3.0.3/3.9.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>zoontek/react-native-permissions (react-native-permissions)</summary> ### [`v3.9.3`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.9.3) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.9.2...3.9.3) - Execute `[CLLocationManager locationServicesEnabled]` in an async way to prevent UI freezes when checking / requesting location permissions on iOS (zoontek/react-native-permissions@82e178f) ### [`v3.9.2`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.9.2) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.9.1...3.9.2) - Remove the necessity to declare `NSLocationAlwaysUsageDescription` as it's deprecated in iOS 17 (fixes [#​806](https://togithub.com/zoontek/react-native-permissions/issues/806)) - Replace missing usage description error logbox with a warning one ### [`v3.9.1`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.9.1) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.9.0...3.9.1) - Fix silent fail `onRequestPermissionsResult` for invalid activities ([#​805](https://togithub.com/zoontek/react-native-permissions/issues/805) by [@​webraptor](https://togithub.com/webraptor)) ### [`v3.9.0`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.9.0) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.8.4...3.9.0) #### Run `setup_permissions` directly in your `Podfile` This release come with an alternative permission linkage system for iOS: calling a function, `setup_permissions` inside your `Podfile`. It offers the same benefits as the `react-native setup-ios-permissions` command (and actually perform the exact same operation), but it lives in your `Podfile`, so there's no need to run it each time your delete your `node_modules` directory. The only requirement is to run `pod install` when your update your `Podfile`, which make much more sense 😄 This method also solves issues with monorepos / dependencies hoisting. To migrate, remove your `reactNativePermissionsIOS` config, and update your `Podfile`: ```diff ### with react-native >= 0.72 - # Resolve react_native_pods.rb with node to allow for hoisting - require Pod::Executable.execute_command('node', ['-p', - 'require.resolve( - "react-native/scripts/react_native_pods.rb", - {paths: [process.argv[1]]}, - )', __dir__]).strip + def node_require(script) + # Resolve script with node to allow for hoisting + require Pod::Executable.execute_command('node', ['-p', + "require.resolve( + '#{script}', + {paths: [process.argv[1]]}, + )", __dir__]).strip + end + node_require('react-native/scripts/react_native_pods.rb') + node_require('react-native-permissions/scripts/setup.rb') ``` ```diff ### with react-native < 0.72 require_relative '../node_modules/react-native/scripts/react_native_pods' require_relative '../node_modules/@​react-native-community/cli-platform-ios/native_modules' + require_relative '../node_modules/react-native-permissions/scripts/setup' ``` Then in the same file, call `setup_permissions` with the wanted permissions: ```ruby ### … platform :ios, min_ios_version_supported prepare_react_native_project! ### ⬇️ uncomment wanted permissions (don't forget to remove the last comma) setup_permissions([ ### 'AppTrackingTransparency', ### 'BluetoothPeripheral', ### 'Calendars', ### 'Camera', ### 'Contacts', ### 'FaceID', ### 'LocationAccuracy', ### 'LocationAlways', ### 'LocationWhenInUse', ### 'MediaLibrary', ### 'Microphone', ### 'Motion', ### 'Notifications', ### 'PhotoLibrary', ### 'PhotoLibraryAddOnly', ### 'Reminders', ### 'SpeechRecognition', ### 'StoreKit' ]) ### … ``` And run `pod install`. Done! ✨ *📌 The React Native CLI plugin still exists and will not be removed until next major version.* *** - `request` now accepts `() => Promise<boolean>` as `rationale` argument.<br>This way, you can display custom rationale alerts instead of [the native ones](https://reactnative.dev/docs/alert) (fixes [zoontek/react-native-permissions#710) ### [`v3.8.4`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.8.4) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.8.3...3.8.4) - Only supports iOS 12.4+ with new architecture to prevent compilation issues ([#​786](https://togithub.com/zoontek/react-native-permissions/issues/786) by [@​hsjoberg](https://togithub.com/hsjoberg)) ### [`v3.8.3`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.8.3) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.8.2...3.8.3) - Use gradle `namespace` conditionally in order to improve old react native version compatibility. *⚠️ Note that this library officially now follows the React Native [releases support policy](https://togithub.com/reactwg/react-native-releases#releases-support-policy). If you have been impacted by this bug, that means you are using an unsupported react native version and should upgrade to the latest.* ### [`v3.8.2`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.8.2) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.8.1...3.8.2) - Update **Support** mention ### [`v3.8.1`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.8.1) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.8.0...3.8.1) - Bump WindowsTargetPlatform by [@​TatianaKapos](https://togithub.com/TatianaKapos) for react-native 0.72 compatibility in [zoontek/react-native-permissions#771 - Update Android config for react-native 0.73 compatibility by [@​felipemillhouse](https://togithub.com/felipemillhouse) in [zoontek/react-native-permissions#782 ### [`v3.8.0`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.8.0) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.7.3...3.8.0) - Add new architecture support ([#​748](https://togithub.com/zoontek/react-native-permissions/issues/748) by [@​WoLewicki](https://togithub.com/WoLewicki)) ### [`v3.7.3`](https://togithub.com/zoontek/react-native-permissions/compare/de06cd3a84c9aee5c4f63810c6f707efa35dba67...863d50d24c20139657d0c0c52fd1137c64348158) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.7.2...3.7.3) ### [`v3.7.2`](https://togithub.com/zoontek/react-native-permissions/compare/5aa5a81f73194b1ebb6b0194d998eec585f98c53...de06cd3a84c9aee5c4f63810c6f707efa35dba67) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.7.1...3.7.2) ### [`v3.7.1`](https://togithub.com/zoontek/react-native-permissions/compare/db4238213dc1c9601d4e03e864144d8fa31b5411...5aa5a81f73194b1ebb6b0194d998eec585f98c53) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.7.0...3.7.1) ### [`v3.7.0`](https://togithub.com/zoontek/react-native-permissions/compare/db9ffd0a97e0803fd166aeef7d559e8e33c62984...db4238213dc1c9601d4e03e864144d8fa31b5411) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.6.1...3.7.0) ### [`v3.6.1`](https://togithub.com/zoontek/react-native-permissions/compare/a5ec1e20dec00f4c606b7c95ede6c459a4e7f605...db9ffd0a97e0803fd166aeef7d559e8e33c62984) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.6.0...3.6.1) ### [`v3.6.0`](https://togithub.com/zoontek/react-native-permissions/compare/b47e58dc23ec88bdba5befa0ce8c85e8ee7b33f6...a5ec1e20dec00f4c606b7c95ede6c459a4e7f605) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.5.0...3.6.0) ### [`v3.5.0`](https://togithub.com/zoontek/react-native-permissions/compare/4e08185f16551711f43bdbfb731cf760e5aa0f41...b47e58dc23ec88bdba5befa0ce8c85e8ee7b33f6) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.4.0...3.5.0) ### [`v3.4.0`](https://togithub.com/zoontek/react-native-permissions/compare/7a9d53eebdc1bc4177aca40846c5b4a2ba214b60...4e08185f16551711f43bdbfb731cf760e5aa0f41) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.3.1...3.4.0) ### [`v3.3.1`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.3.1) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.3.0...3.3.1) - Fix test mock ([#​681](https://togithub.com/zoontek/react-native-permissions/issues/681) by [@​rkaartikeyan](https://togithub.com/rkaartikeyan)) ### [`v3.3.0`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.3.0) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.2.0...3.3.0) - Add `providesAppSettings` support in `NotificationSettings` ([#​678](https://togithub.com/zoontek/react-native-permissions/issues/678) by [@​cwhenderson20](https://togithub.com/cwhenderson20)) ### [`v3.2.0`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.2.0) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.1.0...3.2.0) - Add Android `ACCESS_MEDIA_LOCATION` permission ([#​669](https://togithub.com/zoontek/react-native-permissions/issues/669) by [@​hectoruiz](https://togithub.com/hectoruiz)) ### [`v3.1.0`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.1.0) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.0.6...3.1.0) - Add new Android 12 bluetooth permissions ([#​655](https://togithub.com/zoontek/react-native-permissions/issues/655) by [@​jsimonassi](https://togithub.com/jsimonassi)) - Add App Tracking Transparency instructions in the documentation ([#​657](https://togithub.com/zoontek/react-native-permissions/issues/657) by [@​TheWirv](https://togithub.com/TheWirv)) - Fix react-native-windows reference directory ([#​652](https://togithub.com/zoontek/react-native-permissions/issues/652) by [@​JerryMacedoCastro](https://togithub.com/JerryMacedoCastro)) ### [`v3.0.6`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.0.6) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.0.5...3.0.6) - Make react-native-windows peer dependency optional ([#​656](https://togithub.com/zoontek/react-native-permissions/issues/656) by [@​grit96](https://togithub.com/grit96)) ### [`v3.0.5`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.0.5) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.0.4...3.0.5) - Export `PERMISSIONS` constants in Jest mock ([#​628](https://togithub.com/zoontek/react-native-permissions/issues/628) by [@​1natsu172](https://togithub.com/1natsu172)) ### [`v3.0.4`](https://togithub.com/zoontek/react-native-permissions/releases/tag/3.0.4) [Compare Source](https://togithub.com/zoontek/react-native-permissions/compare/3.0.3...3.0.4) - Fix Android `requestMultiple` not handling `BLOCKED` state properly ([#​609](https://togithub.com/zoontek/react-native-permissions/issues/609) by [@​Iskander508](https://togithub.com/Iskander508)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: valora-bot <valorabot@valoraapp.com> Co-authored-by: Jean Regisser <jean.regisser@gmail.com> Co-authored-by: Satish Ravi <satish.ravi@valoraapp.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In RNW .72, we bump WinUI from 2.7 to 2.8 which targets a higher TargetPlatformMinVersion. This PR bumps the WindowsTargetPlatformMinVersion to the correct version for RNW .72
Test Plan
Tested on React-Native Gallery
Compatibility
Checklist