Register BTree/Bucket as MutableMapping and Set/TreeSet as MutableSet, add missing methods/operators #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to verify they implement the required methods. Turns out they didn't, so implement them.
This means
popitem
for the mappings, andpop/discard/isdisjoint
plus a swath of operators for the sets.Do this in both C and Python. The implementations are probably on the naive side, in that they work with generic iterators and don't try to do any complex structural merging, but that makes them easier to understand and hopefully be correct. Performance shouldn't be too bad, nothing worse than
O(N*logM)
(roughly). The__iand__
method requires extra storage space of up toO(N)
, and__xor__
requires storage of O(N*M).Fixes #121
This was a lot bigger than I expected.