Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required minimum coverage. #4

Merged
merged 2 commits into from Mar 17, 2021
Merged

Fix required minimum coverage. #4

merged 2 commits into from Mar 17, 2021

Conversation

icemac
Copy link
Member

@icemac icemac commented Mar 17, 2021

No description provided.

@icemac icemac requested a review from dataflake March 17, 2021 07:10
@icemac icemac merged commit 0f9aa1a into master Mar 17, 2021
@icemac
Copy link
Member Author

icemac commented Mar 17, 2021

Thank you for reviewing this PR. 😃

@icemac icemac deleted the config-with-zope-product branch March 17, 2021 08:19
@@ -5,6 +5,9 @@ include *.txt
include buildout.cfg
include tox.ini

recursive-include src *.pt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's something I REALLY don't like: I curate MANIFEST.in after running config-package.py to remove all entries that are not relevant. That way we don't get that stupid warning every time the buildout is run or when the package is installed about no matching files for that specification. Now those entries are back, and so is the warning message.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering where these lines came from.

But you are right: The default MANIFEST.in configuration in meta/config has probably too many hard coded entries. We could remove at least some of them. As we have linting for MANIFEST.in in place (which at least checks if too little is included) it does not hurt too much to reduce the default rules. Only the next time a package needing removed rules it has to be updated to include them via .meta.toml. – A PR is welcome, I do not like theses warnings either as they look very professional.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants