Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix required minimum coverage. #4

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Fix required minimum coverage. #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee41189
Configuring for zope-product
Mar 17, 2021
ff45b13
Configuring for zope-product
Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .meta.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# https://github.com/zopefoundation/meta/tree/master/config/zope-product
[meta]
template = "zope-product"
commit-id = "8663e2605e6d9b1f0153ba6cdb4d4bf8286bb002"
commit-id = "af622790bf7aa724913c1929effe5992f422d175"

[python]
with-appveyor = false
Expand All @@ -15,7 +15,7 @@ with-sphinx-doctests = false
use-flake8 = true

[coverage]
fail-under = 85
fail-under = 90

[manifest]
additional-rules = [
Expand Down
3 changes: 3 additions & 0 deletions MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ include *.txt
include buildout.cfg
include tox.ini

recursive-include src *.pt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's something I REALLY don't like: I curate MANIFEST.in after running config-package.py to remove all entries that are not relevant. That way we don't get that stupid warning every time the buildout is run or when the package is installed about no matching files for that specification. Now those entries are back, and so is the warning message.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering where these lines came from.

But you are right: The default MANIFEST.in configuration in meta/config has probably too many hard coded entries. We could remove at least some of them. As we have linting for MANIFEST.in in place (which at least checks if too little is included) it does not hurt too much to reduce the default rules. Only the next time a package needing removed rules it has to be updated to include them via .meta.toml. – A PR is welcome, I do not like theses warnings either as they look very professional.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR open at zopefoundation/meta#86

recursive-include src *.py
recursive-include src *.rst
recursive-include src *.txt
recursive-include src *.zcml
include buildout4.cfg
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ commands =
mkdir -p {toxinidir}/parts/htmlcov
coverage run {envbindir}/test {posargs:-cv}
coverage html
coverage report -m --fail-under=85
coverage report -m --fail-under=90

[coverage:run]
branch = True
Expand Down