Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ICredentialsUpdatedEvent event handler incorrectly calls updateCredentials #60

Merged
merged 2 commits into from Nov 27, 2019
Merged

Fix ICredentialsUpdatedEvent event handler incorrectly calls updateCredentials #60

merged 2 commits into from Nov 27, 2019

Conversation

ericof
Copy link
Member

@ericof ericof commented Nov 27, 2019

Fixes #59

  • Fixed userCredentialsUpdatedHandler: Now calls updateCredentials without passing pas as first argument.
  • Fixed updateCredentials test.

@ericof ericof added the bug label Nov 27, 2019
@dataflake dataflake merged commit 68168ff into master Nov 27, 2019
@dataflake dataflake deleted the fix-59-userCredentialsUpdatedHandler branch November 27, 2019 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataflake dataflake dataflake approved these changes

@ale-rt ale-rt Awaiting requested review from ale-rt

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ICredentialsUpdatedEvent event handler incorrectly calls updateCredentials
2 participants
@ericof @dataflake