Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix creating a temp_folder in py2 #7

Merged
merged 1 commit into from
Oct 2, 2018
Merged

fix creating a temp_folder in py2 #7

merged 1 commit into from
Oct 2, 2018

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented Oct 1, 2018

computeMountPaths in ZServer startup returns unicode in py2

@pbauer pbauer requested a review from icemac October 1, 2018 21:48
davisagli
davisagli approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbauer pbauer merged commit 8d55789 into master Oct 2, 2018
@icemac icemac deleted the fix_creating_temp_folder branch October 2, 2018 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davisagli davisagli davisagli approved these changes

@icemac icemac Awaiting requested review from icemac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pbauer @davisagli