Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace urllib.quote with six.moves.urllib.parse.quote #44

Merged
merged 4 commits into from
Oct 3, 2018
Merged

Conversation

ale-rt
Copy link
Member

@ale-rt ale-rt commented Oct 2, 2018

No description provided.

@ale-rt ale-rt requested a review from icemac October 2, 2018 16:24
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

CHANGES.rst Outdated
@@ -4,6 +4,8 @@ Changelog
4.2 (unreleased)
----------------

- Replace urllib.quote with six.moves.urllib.parse.quote
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix the ZMI for this package? (If yes, this should be mentioned in the change log.)

@icemac icemac merged commit 79e9cc4 into master Oct 3, 2018
@icemac icemac deleted the python3 branch October 3, 2018 10:00
@icemac icemac added the bug label Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants