Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 leftovers. #237

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Remove Python 2 leftovers. #237

merged 3 commits into from
Nov 22, 2023

Conversation

icemac
Copy link
Member

@icemac icemac commented Nov 21, 2023

Fixes #236.

@icemac icemac self-assigned this Nov 21, 2023
@icemac icemac mentioned this pull request Nov 21, 2023
@coveralls
Copy link

coveralls commented Nov 21, 2023

Pull Request Test Coverage Report for Build 6954724829

  • 8 of 13 (61.54%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 73.535%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ZEO/StorageServer.py 1 2 50.0%
src/ZEO/runzeo.py 0 1 0.0%
src/ZEO/tests/testZEOOptions.py 0 1 0.0%
src/ZEO/scripts/zeoqueue.py 0 2 0.0%
Totals Coverage Status
Change from base Build 6927399081: 0.06%
Covered Lines: 7795
Relevant Lines: 10121

💛 - Coveralls

@dataflake
Copy link
Member

If you want to make a 6.0 release the pypy test failures should be fixed first.

@d-maurer
Copy link
Contributor

The failing PyPy3 checks result from a buggy IterationTest.checkIteratorGCStorageTPCAborting test. The test creates an iterator causing an entry in the WeakValueDict _iterators and the set _iterator_ids. The iterator reference is not stored; this means that the iterator can be garbage collected immediately. The test failure is caused because _iterators has less elements than iterator_ids which happens when there has meanwhile been a garbage collection. _assertIteratorIdsEmpty tries to prevent such a race condition by a call to gc.disable() but this can be too late. A fix would be to disable garbage collection before the iterator is created.

@icemac icemac enabled auto-merge (squash) November 22, 2023 07:35
@icemac
Copy link
Member Author

icemac commented Nov 22, 2023

Thank you for reviewing this PR. 😃

@icemac icemac merged commit a6fa4b0 into master Nov 22, 2023
29 checks passed
@icemac icemac deleted the fix-236 branch November 22, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Look for more Python 2 leftovers
6 participants