Fix unbound local error when using the fsoids.py script #295
Conversation
| @@ -699,7 +699,7 @@ def get_refs(a_pickle): | |||
| if isinstance(reference, tuple): | |||
| oid, klass = reference | |||
| elif isinstance(reference, (bytes, str)): | |||
| data, klass = reference, None | |||
| oid, klass = reference, None | |||
There was a problem hiding this comment.
Split in 2 lines to avoid the tuple packing/unpacking.
There was a problem hiding this comment.
But this way it's nicely symmetric with the case above, where reference is a tuple.
|
Python 2.7 fails on Appveyor with syntax errors in mock. I'm pretty sure this is because Appveyor's default pip is too old to pay attention to python_requires metadata and installs the wrong version of mock. A |
I should've looked at the appveyor.yml before making assumptions. We already upgrade pip to the latest version. mock is actually installed by buildout. Suggestion: instead of buildout let's use |
Fixes issues with zc.buildout and version pins (#295 (comment))
Fixes issues with zc.buildout and version pins (zopefoundation#295 (comment))
Fixes issues with zc.buildout and version pins (zopefoundation#295 (comment))
Fixes issues with zc.buildout and version pins (zopefoundation#295 (comment))
|
I would squash and merge the commits if the build passes |
|
I restarted the PyPy3 job which had failed. But now it is green. @pbauer Feel free to merge. |
|
Oops my finger slipped and I accidentally did the suggested squash-and-merge! Thank you everyone! |
…on#295) Co-authored-by: ale-rt <alessandro.pisa@gmail.com>
…foundation#295) ( This is ZODB4 backport of upstream commit fc4c86e ) Co-authored-by: ale-rt <alessandro.pisa@gmail.com>
* 4-nxd: [ZODB4] Fix unbound local error when using the fsoids.py script (zopefoundation#295)
Fix issue mentioned in #285 (comment)
Closes #329 (duplicate)