Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test compatibility with persistent 4.6; test CPython with PURE_PYTHON #296

Merged
merged 1 commit into from Mar 5, 2020
Merged

Fix test compatibility with persistent 4.6; test CPython with PURE_PYTHON #296

merged 1 commit into from Mar 5, 2020

Conversation

jamadden
Copy link
Member

@jamadden jamadden commented Mar 5, 2020

No description provided.

mgedmin
mgedmin approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mgedmin
Copy link
Member

mgedmin commented Mar 5, 2020 •
edited

Appveyor on Python 2.7 is unhappy because it uses zc.buildout to install stuff, and zc.buildout doesn't pay attention to python_requires and gets a version of mock that doesn't work on 2.7.

(Noticed before in #295 (comment))

@jamadden
Copy link
Member Author

jamadden commented Mar 5, 2020

Thanks! I'll take a look at appveyor in a separate branch.

@jamadden jamadden merged commit 6601d63 into master Mar 5, 2020
@jamadden jamadden deleted the pure-python-tests branch March 5, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jamadden @mgedmin