Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml: pin setuptools to 49.6 on pypy3 #328

Merged

Conversation

perrinjerome
Copy link
Contributor

setutools 50.0.0 does not seem compatible with the pypy3 used on travis.

setutools 50.0.0 does not seem compatible with the pypy3 used on travis.
@perrinjerome
Copy link
Contributor Author

https://travis-ci.org/github/zopefoundation/ZODB/jobs/721278991#L217 was a run from last week which succeeded for pyp3, setuptools 49.6.0 was selected. This week the same job https://travis-ci.org/github/zopefoundation/ZODB/jobs/722605925#L214 picks setuptools 50.0.0 with which buildout errors:

$ buildout $BUILOUT_OPTIONS
Traceback (most recent call last):
  File "/home/travis/virtualenv/pypy3.6-7.1.1/bin/buildout", line 5, in <module>
    from zc.buildout.buildout import main
  File "/home/travis/virtualenv/pypy3.6-7.1.1/site-packages/zc/buildout/buildout.py", line 18, in <module>
    import zc.buildout.easy_install
  File "/home/travis/virtualenv/pypy3.6-7.1.1/site-packages/zc/buildout/easy_install.py", line 21, in <module>
    import distutils.errors
  File "/home/travis/virtualenv/pypy3.6-7.1.1/site-packages/_distutils_hack/__init__.py", line 82, in create_module
    return importlib.import_module('._distutils', 'setuptools')
  File "/home/travis/virtualenv/pypy3.6-7.1.1/lib-python/3/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 974, in _gcd_import
  File "<frozen importlib._bootstrap>", line 924, in _sanity_check
SystemError: Parent module 'setuptools' not loaded, cannot perform relative import

I quickly tried pypy v7.3.1 from https://www.pypy.org/download.html and it does not seem to have this problem, so probably once travis ci updates pypy this version pin will no longer be necessary.

Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perrinjerome perrinjerome merged commit 1da7a93 into zopefoundation:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants