Improve readability #741
Merged
Improve readability #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix minor wording issues. modified: docs/zopebook/SearchingZCatalog.rst
modified: docs/zopebook/SearchingZCatalog.rst
Also fix typos, re-arrange text, delete references to very old Zope versions. modified: docs/zopebook/SearchingZCatalog.rst
modified: docs/zopebook/SearchingZCatalog.rst
... also delete paragraph about TextIndexNG, which does not get migrated to Python 3. modified: docs/zopebook/SearchingZCatalog.rst
modified: docs/zopebook/SearchingZCatalog.rst
... also fix typos. modified: docs/zopebook/SearchingZCatalog.rst
jugmac00
force-pushed
the
update-zcatalog-docu
branch
from
2806292
to
78c9d3b
Compare
... also fix typos. modified: docs/zopebook/SearchingZCatalog.rst
modified: docs/zopebook/SearchingZCatalog.rst
.. as both are obsolete. modified: docs/zopebook/SearchingZCatalog.rst
modified: docs/zopebook/SearchingZCatalog.rst
icemac
approved these changes
Dec 12, 2019
|
|
||
| The Add form asks you for an **Id** and a **Title**. Give your | ||
| **ZCatalog** the **Id** ``AnimalCatalog`` and click **Add** to create your new | ||
| **ZCatalog**. The **ZCatalog** icon looks like a folder with a small |
There was a problem hiding this comment.
Nowadays with Bootstrap ZMI the folder is gone, the icon is only a magnifying glass.
|
|
||
| A **ZCatalog** has the following views: ``Contents``, ``Catalog``, | ||
| ``Properties``, ``Indexes``, ``Metadata``, ``Find Objects``, | ||
| ``Advanced``, ``Undo``, ``Security``, and ``Ownership``. |
There was a problem hiding this comment.
Currently there are Query Report and Query Plan following Advanced. But Undo is no longer there.
Suggested change
| ``Advanced``, ``Undo``, ``Security``, and ``Ownership``. | |
| ``Advanced``, ``Query Report``, ``Query Plan``, ``Security``, and ``Ownership``. |
|
@icemac Thanks so much for taking the time to review this pull request! Thanks for your suggestions. I deliberately did not include them in my pr, as then we'd had a document with mixed Zope 2 (at least screenshots) and Zope 4 (menu items) content, as I missed the time to update the document properly for Zope 4/5. With #671 we already have an issue for updating the content to Zope 4/5 - I added a comment there which links to this pull request and adds a note to include your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I have to read through the
Searching and Categorizing Contentchapter of the Zope book anyway, I will improve formatting, fix minor issues like wording and typos, but I do not plan to update the article to be compatible with Zope 4/5 yet (also no new screen shots).All in all I
TextIndexNG3andFieldedTextIndexThank you very much in advance, whoever will go through this longish pr.
I do not know the details what has changed between the early version of Zope described in the chapter and Zope 4/5, but I noticed several things: