Fix test incompatibility with zope.interface 5.0 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent zope.interface versions made Interface.__module__ a readonly
attribute. Without this fix, tests fail on Python 2.7 with
Traceback (most recent call last):
File "/usr/lib/python2.7/doctest.py", line 1315, in __run
compileflags, 1) in test.globs
File "<doctest directive.rst[105]>", line 1, in <module>
class once_iface(FakeModule):
File "/home/mg/src/zopefoundation/martian/src/martian/testing.py", line 65, in __init__
fake_import(cls)
File "/home/mg/src/zopefoundation/martian/src/martian/testing.py", line 33, in fake_import
obj.__module__ = module.__name__
TypeError: readonly attribute
(On Python 3 assignment to a readonly attribute raises an AttributeError
instead, which was already caught.)
Merged
jamadden
approved these changes
Apr 7, 2020
It's in the commit message, which is Good Enough For Me ™️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent zope.interface versions made
Interface.__module__a readonly attribute. Without this fix, tests fail on Python 2.7 with(On Python 3 assignment to a readonly attribute raises an AttributeError instead, which was already caught.)