Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python 3.4 support #19

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Drop Python 3.4 support #19

merged 1 commit into from
Apr 7, 2020

Conversation

mgedmin
Copy link
Member

@mgedmin mgedmin commented Apr 7, 2020

Python 3.4 is EOL.

(This PR is based on top of #18 because otherwise tests would be broken.)

jamadden
jamadden approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@jamadden jamadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This might be a good time to modernize the .travis.yml definitions of pypy and pypy3 (The suffixes are no longer needed.)

icemac
icemac approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mgedmin
Drop Python 3.4
b09c2cc 
Also fix 'tox -p auto' not to coverage report too early
@mgedmin mgedmin merged commit 4a07b19 into master Apr 7, 2020
@mgedmin mgedmin deleted the drop-py34 branch April 7, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamadden jamadden jamadden approved these changes

@icemac icemac icemac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgedmin @icemac @jamadden