Reach 100% coverage #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rage of tests.attrhooks, tests.cucumbers and tests.utils.
Two bug fixes for pure-Python mode: deleting _p_oid and deleting *any* _p attribute.
Deleted _makeOctets since we have native literals everywhere.
Two of the tests for _p_serial weren't catching what we thought they were.
Remove the old workaround for a broken __cmp__.
There are many fewer 'no cover' lines now. Remove the call to copy_reg.constructor---it doesn't do anything anymore except check that the object is callable, there is no registry. Also make timestamp support PURE_PYTHON.
Do this everywhere for simplicity. It slows PyPy down by 3x, but that should still only be around 4s.
mgedmin
approved these changes
Aug 1, 2018
persistent/tests/test_persistence.py
Outdated
| def mru(oid): | ||
| # Mimic what the real cache does | ||
| if oid not in jar._cache._mru: | ||
| raise KeyError(oid) | ||
| orig_mru(oid) | ||
| raise AssertionError("Shold never get here") |
|
Thanks. For the most part it's very small changes, just quite a few of them. The most potentially disruptive change is in init.py, which I simplified substantially, including taking out an attempted import of I'll add this to CHANGES. |
[skip ci] Update PyPI links in readme. Fix typo in test_persistence.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tox only for now, coveralls coming in a followup PR or commit.
There are also two minor pure-python bug fixes I discovered.
Addresses #76.